Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wolfSSL_X509_get_ext_d2i compatibility #8069

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dclaisse
Copy link

Description

  • When dealing with authority key id extension, conform to RFC3280/RFC5280 and populate the keyid field with an ASN1 string containing the key id.
  • When dealing with subject key id extension, return an ASN1 string containing the key id instead of an extension stack, to mimic OpenSSL behavior.
  • This mainly aims to improve compatibility, for instance with this patch one is able to leverage the HAProxy's issuers-chain-path directive, as without it HAProxy is not able to find the relevant intermediate certificate.

Fixes zd# N/A

Testing

How did you test?
Tested on our production load balancers, HAProxy is now able to link intermediate certificates.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

* When dealing with authority key id extension, conform to
  RFC3280/RFC5280 and populate the keyid field with an ASN1 string
  containing the key id.
* When dealing with subject key id extension, return an ASN1 string
  containing the key id instead of an extension stack, to mimic OpenSSL
  behavior.
@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

@kareem-wolfssl
Copy link
Contributor

OK to test. Contributor agreement approved.

@dgarske
Copy link
Contributor

dgarske commented Oct 21, 2024

Retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants