Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VS2022 DLL Release options.h build configuration #8112

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add VS2022 DLL Release options.h build configuration #8112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ config.*
!cmake/config.in
*Debug/
*Release/
*Release (options.h)/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only for release? Where is the README to go along with these new VS 2022 projects? Would be nice to explain the various configuration options and where the user_settings.h is coming from.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only for release?

The initial settings for only release build was as related to wolfSSL/wolfcrypt_nodejs#8 where debugging was unlikely.

It was also an exploratory PR, to see if there was interest in an options.h build for Windows.

But you are right; there should be a debug option. Potentially also options.h configs for 32bit debug and release, too.

Where is the README to go along with these new VS 2022 projects?

I neglected that, as I was documenting in an upcoming blog that I would have referred to.

I'll add some README info, as well.

Would be nice to explain the various configuration options and where the user_settings.h is coming from.

That's also in the upcoming blog, but you ae correct it should also be in the README.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like documentation needs to be added similar to PR description?

*.ncb
*.suo
*.sdf
Expand Down
Loading
Loading