fix read() in WolfSSLInputStream to reflect end of stream #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cconlon
requested changes
May 22, 2024
| @@ -2383,7 +2383,12 @@ public synchronized int read() throws IOException { | |||
| byte[] data = new byte[1]; | |||
|
|
|||
| try { | |||
| this.read(data, 0, 1); | |||
| int ret = this.read(data, 0, 1); | |||
There was a problem hiding this comment.
Can you declare int ret; at the top of the method, above byte[] data = new byte[1]? That will make us consistent in putting variable declarations at the top of the method in most cases.
cconlon
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling the read() method (with no parameters) on a WolfSSLInputStream will now reflect the end of a stream in the return value. If the end of the stream has been reached, -1 should be returned instead of a byte (as noted here: https://docs.oracle.com/javase/8/docs/api/java/io/InputStream.html#read-- ).