-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python dev - Build python packages for each of supported python versions. #15931
Conversation
5614aad
to
119cac8
Compare
Things to point out that a reviewer would want to look at:
Things that would make life easier:
|
I like this approach! it seems like it won't confuse our scanner/advisory feed because it's still one version of each python library just "linked" against different python versions. |
c79bf48
to
d259615
Compare
I don't think the build failure right now is due to my changes, but rather the dependency resolver. I do not think it is a circular dependency (which did cause issues earlier)
py3-tomli.yaml does build a py3.10-tomli-2.0.1-r5.apk. It does build locally given this order:
|
This is really good.
|
we may need to land it first / separately, as that's install check rather than build check. And install checks are done after each build, rather than after all builds are completed first. |
At this point most things should use the py/pip-build-install pipeline and generally look like py3-pyyaml Also: * rename cython.yaml, numpy.yaml to py3-<name> These are python packages and present in pypi, for consistency, name them like other python packages. Co-authored-by: Dimitri John Ledkov <[email protected]>
flit-core has bootstrap_install.py to handle this, so we use it. pip doesn't stricktly depend on wheel, although buidling many projects assumes that it is there.
You can get started with: make package/pip-zipapp \ package/py3-{supported-python,setuptools,installer,wheel,pip} Then most of core deps are built.
Close in favor of #20318 |
I need to write some doc for this PR.