Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different authentication methods #59

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eakorolev
Copy link

Motivation

I've tried to connect to Pulsar with token authentication, but client does not support this auth mode.

Modifications

  1. I've split TLSConfig and tls auth mode. TLSConfig is now used to set up connection.
  2. I added Authentication interface and some basic implementations.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is already covered by existing tests.

1. Split ClientConfig and ManagedClientConfig (revert to Comcast)
2. Rename ConsumerConfig to ManagedConsumerConfig
3. Rename ProducerConfig to ManagedProducerConfig
4. Rename NewPartitionManagedConsumer() to NewManagedPartitionConsumer() (according to ManagedPartitionConsumer type name and NewManagedPartitionProducer())
5. Reorder code: type constructor, type definition, type methods
6. Unpublish fields that are not used by other pulsar-go-client packages (revert to Comcast)
7. Fixed build error in managed_consumer.go (Go 1.13 faults at https://github.com/wolfstudy/pulsar-client-go/blob/6c1405cf4104fe07f70bbd2a6d26197dd2d8e21e/core/manage/managed_consumer.go#L216)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant