-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SG painting on image object #2011
Open
ghost
wants to merge
96
commits into
master
Choose a base branch
from
sg-image-drawing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to scene background
ghost
mentioned this pull request
Oct 23, 2020
2 tasks
Vlad Stepura seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature description
The feature allows drawing on image objects in the shot-generator scene. It allows drawing on multiple images at the same time, by selecting the brush tab in image object it enables drawing mode in which you can't interact with objects (moving them and selecting them) but you can draw on images. Drawing on images updates image objects across the apps(shot-explorer and XR).
Changed image geometry to rounded plane geometry.
Solution description
To easily control all images and drawing on them their drawing material is stored in SceneManager. When image created it creates a specific drawing material that has a canvas, and it passes this object to SceneManager. SceneManager has all mouse events which is necessary for drawing, the drawing is only allowed when drawing mode is enabled. In order to change image texture( saving current drawing), each image uses a temp texture while the scene isn't saved. If the scene was saved image temp texture changes to original texture with new drawing in it, if the scene wasn't saved the temp texture file gets cleaned up.
Task
Future Plans