Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for OpenRaster format. #505

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Banbury
Copy link

@Banbury Banbury commented Aug 12, 2017

Storyboards can now be edited in Krita and other programs, that support
the OpenRaster format.

Known problems:

  • It is slow. Reloading an image after editing it, takes several seconds. It would be good, if there were a way to block the GUI and display an hour glass cursor.
  • No toolbar icon. I wasn't able to create an SVG, that would show up in Storyboarder. I reused the Photoshop icon as a placeholder.

I had a lot of problems with the current layer system. That's why I created those issues :).

Storyboards can now be edited in Krita and other programs, that support
the OpenRaster format.
@setpixel
Copy link
Collaborator

@Banbury could you make it a preference so that it replaces the photoshop button with Open Raster? Also, what should the icon look like? I can design it.

@Banbury
Copy link
Author

Banbury commented Aug 13, 2017

@setpixel A switch in the preferences I could do. But I don't know how to switch icons in the toolbar. That's hard coded in the HTML file.

I've attached the icon, I wanted to use. But it doesn't show up. That's the Krita logo btw.

Calligra_Krita_icon_bw.zip

@rawbee
Copy link
Collaborator

rawbee commented Aug 14, 2017

I think the way I would like to see this implemented is something like this:

  1. Add a preference for the user to be able to switch which external editor is used.
  2. Add the Open Raster reading and writing capabilities to file-helper.js
  3. Update the openInEditor function in main-window.js to look at the preference, and generate the correct file.
  4. Update the openInEditor function in main-window.js to watch, read, and correctly update the Open Raster and their corresponding boards.

Storyboards can now be edited in Krita and other programs, that support
the OpenRaster format.
There is now an option in the preference dialog to select the external
graphics editor to use.
@Banbury
Copy link
Author

Banbury commented Sep 2, 2017

@rawbee I have updated the PR as per your suggestions. Could you have a look, if that is okay now.

I have added support for radio buttons in the preferences. But someone needs to apply some styling to them. I'm no artist.

@supertobi supertobi mentioned this pull request Sep 12, 2017
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants