Changing library from ART to react-native-svg #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes ART and adds react-native-svg as the drawing library for producing the barcode. This change is to support the deprecation of ART from the ReactNative libraries. The react community ART library is not linked in Expo v36 projects. SVG is the preferred method. This change is linked to issue wonsikin#49 wonsikin#49
|
Thanks for your contribution. But we decide to use @react-native-community/art |
|
thanks for this, only way I could get it working on iOS using Expo |
|
same here, not using expo and having the same issue. |
|
Switching to https://www.npmjs.com/package/expo-barcode-generator solves this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes ART and adds react-native-svg as the drawing library for producing the barcode. This change is to support the deprecation of ART from the ReactNative libraries. The react community ART library is not linked in Expo v36 projects. SVG is the preferred method. This change is linked to issue #49 #49
There are no tests for this changes. Changes will need to be made to the readme first.