Ensure viewmodel is unsubscribed when exiting

woocommerce · Jan 10, 2025 · 792072c · 792072c
1 parent 0fab351
commit 792072c
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/...kotlin/com/woocommerce/android/ui/products/variations/VariationsBulkUpdateBaseFragment.kt b/...kotlin/com/woocommerce/android/ui/products/variations/VariationsBulkUpdateBaseFragment.kt
@@ -53,6 +53,7 @@ abstract class VariationsBulkUpdateBaseFragment(@LayoutRes layoutId: Int) : Base
                             viewModel.onDoneClicked()
                             true
                         }
+
                         else -> false
                     }
                 }
@@ -68,7 +69,12 @@ abstract class VariationsBulkUpdateBaseFragment(@LayoutRes layoutId: Int) : Base
                     ActivityUtils.hideKeyboard(requireActivity())
                     uiMessageResolver.showSnack(event.message)
                 }
-                is MultiLiveEvent.Event.Exit -> requireActivity().onBackPressedDispatcher.onBackPressed()
+
+                is MultiLiveEvent.Event.Exit -> {
+                    // Ensure subsequent Exit events are ignored to avoid IllegalStateException
+                    viewModel.event.removeObservers(viewLifecycleOwner)
+                    requireActivity().onBackPressedDispatcher.onBackPressed()
+                }
             }
         }
     }