Disable formatting rules from fluxc and login modules

They were not enabled/configured back in FluxC, so enabling them here causes hundreds of violations. Adjust `MagicNumber` rule to also fit newly added codebase
woocommerce · Jan 17, 2025 · 7b5ebd2 · 7b5ebd2
1 parent 3234739
commit 7b5ebd2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/config/detekt/detekt.yml b/config/detekt/detekt.yml
@@ -15,6 +15,7 @@ complexity:
 formatting:
   active: true
   autoCorrect: true
+  excludes: ['**/fluxc/**', '**/login/**']
   Indentation:
     active: true
     autoCorrect: true
@@ -27,6 +28,8 @@ style:
     active: true
     ignoreAnnotated: [ 'Module' ]
   MagicNumber:
+    ignoreEnums: true
+    ignorePropertyDeclaration: true
     ignoreAnnotated: [ 'Composable' ]
   UnusedPrivateMember:
     ignoreAnnotated: [ 'Preview', 'LightDarkThemePreviews', 'OrientationPreviews', 'FontScalePreviews', 'LayoutDirectionPreviews' ]

diff --git a/libs/login/src/main/java/org/wordpress/android/login/SignupConfirmationFragment.kt b/libs/login/src/main/java/org/wordpress/android/login/SignupConfirmationFragment.kt
@@ -64,6 +64,7 @@ class SignupConfirmationFragment : Fragment(), MenuProvider {
         AndroidSupportInjection.inject(this)
         super.onAttach(context)
         if (context !is LoginListener) {
+            @Suppress("TooGenericExceptionThrown")
             throw RuntimeException("$context must implement LoginListener")
         }
         mLoginListener = context