Skip to content

Commit

Permalink
Merge pull request #13265 from Akshaykomar890/trunk
Browse files Browse the repository at this point in the history
Fix Spinner Ripple Effect in WCMaterialOutlinedSpinnerView.
  • Loading branch information
malinajirka authored Jan 13, 2025
2 parents fe05fe6 + 4a6b371 commit 7fa5ee8
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 1 deletion.
22 changes: 22 additions & 0 deletions WooCommerce/src/main/res/drawable/custom_ripple.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?xml version="1.0" encoding="utf-8"?>
<layer-list xmlns:android="http://schemas.android.com/apk/res/android">
<!-- Background shape or color -->
<item>
<shape android:shape="rectangle">
<solid android:color="@android:color/transparent" />
</shape>
</item>

<!-- Ripple effect -->
<item android:left="@dimen/minor_10" android:top="@dimen/minor_75" android:right="@dimen/minor_10" android:bottom="@dimen/minor_00">
<ripple android:color="?attr/colorControlHighlight">
<item android:id="@android:id/mask">
<shape android:shape="rectangle">
<solid android:color="?attr/colorAccent" />
</shape>
</item>
</ripple>
</item>
</layer-list>


2 changes: 1 addition & 1 deletion WooCommerce/src/main/res/values/styles_base.xml
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ theme across the entire app. Overridden versions should be added to the styles.x
<item name="endIconTint">@color/color_on_surface_medium_selector</item>
<item name="endIconTintMode">src_atop</item>
<item name="android:cursorVisible">false</item>
<item name="android:background">?attr/selectableItemBackground</item>
<item name="android:background">@drawable/custom_ripple</item>
<item name="android:focusable">true</item>
<item name="android:focusableInTouchMode">true</item>
</style>
Expand Down

0 comments on commit 7fa5ee8

Please sign in to comment.