Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Login] Show magic link screen for suspicious emails #13335

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

[Login] Show magic link screen for suspicious emails #13335

wants to merge 3 commits into from
+8 −50

Conversation

hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Jan 16, 2025 •
edited
Loading

Closes: #13321

Depends on wordpress-mobile/WordPress-Login-Flow-Android#156

Description

This PR updates the login library to bring the changes of the above PR, which implements the first part of improving the login flow for suspicious emails.

Steps to reproduce

  1. With the app already signed in, open ApiFaker and add a fake matching the following:
Endpoint type: WordPress.com
Endpoint path: /v1.1/users/%/auth_options
Response status code: 403
Response body: 
{
        "error": "email_login_not_allowed",
        "message": "Please log in using your WordPress.com username instead of your email address."
}
  1. Logout
  2. Enter the address of a Jetpack connected site
  3. Enter email address of a WordPress.com account

Testing information

  • Confirm that the the app shows the Magic Link
  • Confirm Magic Link login works.

The tests that have been performed

^

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@hichamboushaba hichamboushaba added type: enhancement A request for an enhancement. status: do not merge Dependent on another PR, ready for review but not ready for merge. feature: login Related to any part of the log in or sign in flow, or authentication. labels Jan 16, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 16, 2025 •
edited
Loading

2 Errors
🚫 This PR is tagged with status: do not merge label(s).
🚫 PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

Project dependencies changes

The following changes in project dependencies were detected (configuration vanillaReleaseRuntimeClasspath):

list 
Removed Dependencies
androidx.credentials:credentials:1.2.0
androidx.credentials:credentials-play-services-auth:1.2.0
com.google.android.gms:play-services-fido:20.1.0
com.google.android.libraries.identity.googleid:googleid:1.1.0

Upgraded Dependencies
com.google.android.gms:play-services-auth:20.2.0, (changed from 20.7.0)
com.google.android.gms:play-services-auth-base:18.0.1, (changed from 18.0.4)
com.google.android.gms:play-services-basement:18.1.0, (changed from 18.2.0)
org.wordpress:login:156-98aa2c6174009b24253133b6733be119b70b7178 FAILED, (changed from 1.19.0)
tree 
 +--- com.google.firebase:firebase-messaging -> 23.4.0
-|    +--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0
+|    +--- com.google.android.gms:play-services-basement:18.1.0
 |    +--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2
-|    |    \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |    \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    +--- com.google.firebase:firebase-iid-interop:17.1.0
-|    |    \--- com.google.android.gms:play-services-basement:17.0.0 -> 18.2.0 (*)
+|    |    \--- com.google.android.gms:play-services-basement:17.0.0 -> 18.1.0 (*)
 |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0
-|    |    \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |    \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    +--- com.google.android.gms:play-services-cloud-messaging:17.1.0
-|    |    \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
+|    |    \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
 |    +--- com.google.android.gms:play-services-stats:17.0.2
-|    |    \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
+|    |    \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
 |    +--- com.google.firebase:firebase-measurement-connector:19.0.0
-|    |    \--- com.google.android.gms:play-services-basement:17.0.0 -> 18.2.0 (*)
+|    |    \--- com.google.android.gms:play-services-basement:17.0.0 -> 18.1.0 (*)
 |    \--- com.google.firebase:firebase-common:20.4.2
-|         \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|         \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 +--- com.google.firebase:firebase-config -> 21.6.0
 |    \--- com.google.firebase:firebase-abt:21.1.1
-|         \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|         \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 +--- com.google.firebase:firebase-analytics -> 21.5.0
 |    +--- com.google.android.gms:play-services-measurement:21.5.0
 |    |    +--- com.google.android.gms:play-services-ads-identifier:18.0.0
-|    |    |    \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
+|    |    |    \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
-|    |    +--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |    +--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    |    +--- com.google.android.gms:play-services-measurement-base:21.5.0
-|    |    |    \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |    |    \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    |    \--- com.google.android.gms:play-services-measurement-impl:21.5.0
-|    |         \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |         \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    +--- com.google.android.gms:play-services-measurement-api:21.5.0
-|    |    +--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |    +--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    |    \--- com.google.android.gms:play-services-measurement-sdk-api:21.5.0
-|    |         \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |         \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    \--- com.google.android.gms:play-services-measurement-sdk:21.5.0
-|         \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|         \--- com.google.android.gms:play-services-basement:18.1.0 (*)
-+--- com.google.android.gms:play-services-auth:20.2.0 -> 20.7.0
-|    +--- androidx.fragment:fragment:1.0.0 -> 1.8.5 (*)
-|    +--- androidx.loader:loader:1.0.0 (*)
-|    +--- com.google.android.gms:play-services-auth-api-phone:18.0.1
-|    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
-|    |    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
-|    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
-|    +--- com.google.android.gms:play-services-auth-base:18.0.4
-|    |    +--- androidx.collection:collection:1.0.0 -> 1.4.0 (*)
-|    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
-|    |    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
-|    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
-|    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
-|    +--- com.google.android.gms:play-services-basement:18.2.0 (*)
-|    +--- com.google.android.gms:play-services-fido:20.0.1 -> 20.1.0
-|    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
-|    |    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
-|    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
-|    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
++--- com.google.android.gms:play-services-auth:20.2.0
+|    +--- androidx.fragment:fragment:1.0.0 -> 1.8.5 (*)
+|    +--- androidx.loader:loader:1.0.0 (*)
+|    +--- com.google.android.gms:play-services-auth-api-phone:18.0.1
+|    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
+|    |    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
+|    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
+|    +--- com.google.android.gms:play-services-auth-base:18.0.1
+|    |    +--- androidx.collection:collection:1.0.0 -> 1.4.0 (*)
+|    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
+|    |    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
+|    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
+|    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
+|    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
+|    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
-+--- org.wordpress:login:1.19.0
-|    +--- com.gravatar:gravatar:0.2.0
-|    |    +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
-|    |    +--- com.squareup.retrofit2:retrofit:2.9.0
-|    |    |    \--- com.squareup.okhttp3:okhttp:3.14.9 -> 4.12.0 (*)
-|    |    +--- com.squareup.retrofit2:converter-gson:2.9.0
-|    |    |    +--- com.squareup.retrofit2:retrofit:2.9.0 (*)
-|    |    |    \--- com.google.code.gson:gson:2.8.5 -> 2.10.1
-|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.3 -> 1.8.1 (*)
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.21 (*)
-|    +--- androidx.appcompat:appcompat:1.6.1 (*)
-|    +--- androidx.constraintlayout:constraintlayout:2.0.4 -> 2.1.4 (*)
-|    +--- com.google.android.material:material:1.2.1 -> 1.12.0 (*)
-|    +--- androidx.core:core:1.12.0 -> 1.13.1 (*)
-|    +--- com.github.bumptech.glide:glide:4.12.0 -> 4.16.0
-|    |    +--- com.github.bumptech.glide:gifdecoder:4.16.0
-|    |    |    \--- androidx.annotation:annotation:1.5.0 -> 1.8.1 (*)
-|    |    +--- com.github.bumptech.glide:disklrucache:4.16.0
-|    |    +--- com.github.bumptech.glide:annotations:4.16.0
-|    |    +--- androidx.fragment:fragment:1.3.6 -> 1.8.5 (*)
-|    |    +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
-|    |    +--- androidx.exifinterface:exifinterface:1.3.6 (*)
-|    |    \--- androidx.tracing:tracing:1.0.0 (*)
-|    +--- androidx.credentials:credentials:1.2.0
-|    |    +--- androidx.annotation:annotation:1.5.0 -> 1.8.1 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
-|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.1 -> 1.8.1 (*)
-|    |    \--- androidx.credentials:credentials-play-services-auth:1.2.0 (c)
-|    +--- androidx.credentials:credentials-play-services-auth:1.2.0
-|    |    +--- androidx.credentials:credentials:1.2.0 (*)
-|    |    +--- com.google.android.gms:play-services-auth:20.7.0 (*)
-|    |    +--- com.google.android.gms:play-services-fido:20.1.0 (*)
-|    |    +--- com.google.android.libraries.identity.googleid:googleid:1.1.0
-|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.0 -> 2.0.21 (*)
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
-|    |    \--- androidx.credentials:credentials:1.2.0 (c)
-|    +--- com.google.dagger:dagger:2.47 -> 2.51.1 (*)
-|    +--- com.google.dagger:dagger-android-support:2.47 -> 2.50
-|    |    +--- com.google.dagger:dagger:2.50 -> 2.51.1 (*)
-|    |    +--- com.google.dagger:dagger-android:2.50
-|    |    |    +--- com.google.dagger:dagger:2.50 -> 2.51.1 (*)
-|    |    |    +--- com.google.dagger:dagger-lint-aar:2.50
-|    |    |    +--- androidx.annotation:annotation:1.2.0 -> 1.8.1 (*)
-|    |    |    \--- javax.inject:javax.inject:1
-|    |    +--- com.google.dagger:dagger-lint-aar:2.50
-|    |    +--- androidx.activity:activity:1.5.1 -> 1.8.1 (*)
-|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.8.1 (*)
-|    |    +--- androidx.appcompat:appcompat:1.3.1 -> 1.6.1 (*)
-|    |    +--- androidx.fragment:fragment:1.5.1 -> 1.8.5 (*)
-|    |    +--- androidx.lifecycle:lifecycle-common:2.5.1 -> 2.8.7 (*)
-|    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 -> 2.8.7 (*)
-|    |    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 -> 2.8.7 (*)
-|    |    \--- javax.inject:javax.inject:1
-|    +--- com.google.android.gms:play-services-auth:18.1.0 -> 20.7.0 (*)
-|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.21 (*)
++--- org.wordpress:login:156-98aa2c6174009b24253133b6733be119b70b7178 FAILED
 +--- org.wordpress.aztec:glide-loader:v2.1.4
-|    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
+|    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0
+|         +--- com.github.bumptech.glide:gifdecoder:4.16.0
+|         |    \--- androidx.annotation:annotation:1.5.0 -> 1.8.1 (*)
+|         +--- com.github.bumptech.glide:disklrucache:4.16.0
+|         +--- com.github.bumptech.glide:annotations:4.16.0
+|         +--- androidx.fragment:fragment:1.3.6 -> 1.8.5 (*)
+|         +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
+|         +--- androidx.exifinterface:exifinterface:1.3.6 (*)
+|         \--- androidx.tracing:tracing:1.0.0 (*)
-+--- com.gravatar:gravatar:0.2.0 (*)
++--- com.gravatar:gravatar:0.2.0
+|    +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+|    +--- com.squareup.retrofit2:retrofit:2.9.0
+|    |    \--- com.squareup.okhttp3:okhttp:3.14.9 -> 4.12.0 (*)
+|    +--- com.squareup.retrofit2:converter-gson:2.9.0
+|    |    +--- com.squareup.retrofit2:retrofit:2.9.0 (*)
+|    |    \--- com.google.code.gson:gson:2.8.5 -> 2.10.1
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.3 -> 1.8.1 (*)
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.21 (*)
 +--- project :libs:cardreader
 |    \--- com.stripe:stripeterminal-localmobile:3.7.1
 |         +--- com.google.android.gms:play-services-safetynet:18.0.1
-|         |    \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
+|         |    \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
 |         \--- com.google.android.play:integrity:1.1.0
-|              \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|              \--- com.google.android.gms:play-services-basement:18.1.0 (*)
-+--- com.google.dagger:dagger-android-support:2.50 (*)
++--- com.google.dagger:dagger-android-support:2.50
+|    +--- com.google.dagger:dagger:2.50 -> 2.51.1 (*)
+|    +--- com.google.dagger:dagger-android:2.50
+|    |    +--- com.google.dagger:dagger:2.50 -> 2.51.1 (*)
+|    |    +--- com.google.dagger:dagger-lint-aar:2.50
+|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.8.1 (*)
+|    |    \--- javax.inject:javax.inject:1
+|    +--- com.google.dagger:dagger-lint-aar:2.50
+|    +--- androidx.activity:activity:1.5.1 -> 1.8.1 (*)
+|    +--- androidx.annotation:annotation:1.2.0 -> 1.8.1 (*)
+|    +--- androidx.appcompat:appcompat:1.3.1 -> 1.6.1 (*)
+|    +--- androidx.fragment:fragment:1.5.1 -> 1.8.5 (*)
+|    +--- androidx.lifecycle:lifecycle-common:2.5.1 -> 2.8.7 (*)
+|    +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 -> 2.8.7 (*)
+|    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 -> 2.8.7 (*)
+|    \--- javax.inject:javax.inject:1
 +--- com.google.android.play:app-update:2.1.0
-|    \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 +--- com.google.android.play:review:2.0.1
-|    \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 +--- com.google.android.gms:play-services-code-scanner:16.1.0
-|    +--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    +--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    \--- com.google.mlkit:barcode-scanning-common:17.0.0
-|         +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
+|         +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
 |         \--- com.google.mlkit:vision-common:17.0.0 -> 17.3.0
-|              +--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|              +--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |              \--- com.google.mlkit:common:18.6.0 -> 18.9.0
-|                   \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|                   \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 +--- com.google.mlkit:text-recognition:16.0.0
-|    +--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    +--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    +--- com.google.android.gms:play-services-mlkit-text-recognition:19.0.0
-|    |    +--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |    +--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    |    \--- com.google.android.gms:play-services-mlkit-text-recognition-common:19.0.0
-|    |         +--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |         +--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    |         \--- com.google.mlkit:vision-interfaces:16.2.0
-|    |              \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |              \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    \--- com.google.mlkit:text-recognition-bundled-common:16.0.0
-|         \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|         \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 +--- com.google.android.gms:play-services-mlkit-text-recognition-japanese:16.0.0
-|    \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 +--- com.google.android.gms:play-services-mlkit-text-recognition-chinese:16.0.0
-|    \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 +--- com.google.android.gms:play-services-mlkit-text-recognition-korean:16.0.0
-|    \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 +--- com.google.mlkit:barcode-scanning:17.2.0
-|    +--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    +--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    \--- com.google.android.gms:play-services-mlkit-barcode-scanning:18.3.0
-|         \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|         \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 \--- com.google.android.gms:play-services-wearable:18.1.0
-     \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
+     \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit5c7bbc9
Direct Downloadwoocommerce-wear-prototype-build-pr13335-5c7bbc9.apk

@hichamboushaba hichamboushaba mentioned this pull request Jan 16, 2025
Open
hichamboushaba
hichamboushaba commented Jan 17, 2025
View reviewed changes
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/login/LoginActivity.kt
private fun showEmailPasswordScreen(
email: String?,
verifyEmail: Boolean,
password: String? = null
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part about prefilling the password was used just for the account signup, given we don't support this anymore, I deleted it, and deleted its code from the Fragment as well.

@hichamboushaba hichamboushaba requested review from irfano, JorgeMucientes and hafizrahman and removed request for irfano and JorgeMucientes January 17, 2025 10:02
@hichamboushaba hichamboushaba marked this pull request as ready for review January 17, 2025 10:02
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit5c7bbc9
Direct Downloadwoocommerce-prototype-build-pr13335-5c7bbc9.apk

@irfano irfano self-assigned this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hafizrahman hafizrahman Awaiting requested review from hafizrahman

@irfano irfano Awaiting requested review from irfano

@JorgeMucientes JorgeMucientes Awaiting requested review from JorgeMucientes

At least 1 approving review is required to merge this pull request.

Assignees

@irfano irfano

Labels
feature: login Related to any part of the log in or sign in flow, or authentication. status: do not merge Dependent on another PR, ready for review but not ready for merge. type: enhancement A request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Login] Improve login flow for accounts with suspicious emails
4 participants
@hichamboushaba @dangermattic @wpmobilebot @irfano