[Login] Show magic link screen for suspicious emails #13335

hichamboushaba · 2025-01-16T15:39:53Z

Depends on wordpress-mobile/WordPress-Login-Flow-Android#156

Description

This PR updates the login library to bring the changes of the above PR, which implements the first part of improving the login flow for suspicious emails.

Steps to reproduce

With the app already signed in, open ApiFaker and add a fake matching the following:

Endpoint type: WordPress.com
Endpoint path: /v1.1/users/%/auth_options
Response status code: 403
Response body: 
{
        "error": "email_login_not_allowed",
        "message": "Please log in using your WordPress.com username instead of your email address."
}

Logout
Enter the address of a Jetpack connected site
Enter email address of a WordPress.com account

Testing information

Confirm that the the app shows the Magic Link
Confirm Magic Link login works.

The tests that have been performed

^

Images/gif

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

dangermattic · 2025-01-16T15:40:47Z

	2 Errors
🚫	Please ensure the PR has the `category: tracks` label.
🚫	PR is not assigned to a milestone.

	1 Message
📖	This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed: The tracks events must be validated in the Tracks system. Verify the internal Tracks spreadsheet has also been updated. Please consider registering any new events. The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

wpmobilebot · 2025-01-16T15:43:58Z

Project dependencies changes

The following changes in project dependencies were detected (configuration vanillaReleaseRuntimeClasspath):

list

Removed Dependencies
androidx.credentials:credentials:1.2.0
androidx.credentials:credentials-play-services-auth:1.2.0
com.google.android.gms:play-services-fido:20.1.0
com.google.android.libraries.identity.googleid:googleid:1.1.0

Upgraded Dependencies
com.google.android.gms:play-services-auth:20.2.0, (changed from 20.7.0)
com.google.android.gms:play-services-auth-base:18.0.1, (changed from 18.0.4)
com.google.android.gms:play-services-basement:18.1.0, (changed from 18.2.0)
org.wordpress:login:156-98aa2c6174009b24253133b6733be119b70b7178 FAILED, (changed from 1.19.0)

tree

 +--- com.google.firebase:firebase-messaging -> 23.4.0
-|    +--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0
+|    +--- com.google.android.gms:play-services-basement:18.1.0
 |    +--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2
-|    |    \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |    \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    +--- com.google.firebase:firebase-iid-interop:17.1.0
-|    |    \--- com.google.android.gms:play-services-basement:17.0.0 -> 18.2.0 (*)
+|    |    \--- com.google.android.gms:play-services-basement:17.0.0 -> 18.1.0 (*)
 |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0
-|    |    \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |    \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    +--- com.google.android.gms:play-services-cloud-messaging:17.1.0
-|    |    \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
+|    |    \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
 |    +--- com.google.android.gms:play-services-stats:17.0.2
-|    |    \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
+|    |    \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
 |    +--- com.google.firebase:firebase-measurement-connector:19.0.0
-|    |    \--- com.google.android.gms:play-services-basement:17.0.0 -> 18.2.0 (*)
+|    |    \--- com.google.android.gms:play-services-basement:17.0.0 -> 18.1.0 (*)
 |    \--- com.google.firebase:firebase-common:20.4.2
-|         \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|         \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 +--- com.google.firebase:firebase-config -> 21.6.0
 |    \--- com.google.firebase:firebase-abt:21.1.1
-|         \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|         \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 +--- com.google.firebase:firebase-analytics -> 21.5.0
 |    +--- com.google.android.gms:play-services-measurement:21.5.0
 |    |    +--- com.google.android.gms:play-services-ads-identifier:18.0.0
-|    |    |    \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
+|    |    |    \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
-|    |    +--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |    +--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    |    +--- com.google.android.gms:play-services-measurement-base:21.5.0
-|    |    |    \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |    |    \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    |    \--- com.google.android.gms:play-services-measurement-impl:21.5.0
-|    |         \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |         \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    +--- com.google.android.gms:play-services-measurement-api:21.5.0
-|    |    +--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |    +--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    |    \--- com.google.android.gms:play-services-measurement-sdk-api:21.5.0
-|    |         \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |         \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    \--- com.google.android.gms:play-services-measurement-sdk:21.5.0
-|         \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|         \--- com.google.android.gms:play-services-basement:18.1.0 (*)
-+--- com.google.android.gms:play-services-auth:20.2.0 -> 20.7.0
-|    +--- androidx.fragment:fragment:1.0.0 -> 1.8.5 (*)
-|    +--- androidx.loader:loader:1.0.0 (*)
-|    +--- com.google.android.gms:play-services-auth-api-phone:18.0.1
-|    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
-|    |    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
-|    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
-|    +--- com.google.android.gms:play-services-auth-base:18.0.4
-|    |    +--- androidx.collection:collection:1.0.0 -> 1.4.0 (*)
-|    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
-|    |    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
-|    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
-|    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
-|    +--- com.google.android.gms:play-services-basement:18.2.0 (*)
-|    +--- com.google.android.gms:play-services-fido:20.0.1 -> 20.1.0
-|    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
-|    |    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
-|    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
-|    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
++--- com.google.android.gms:play-services-auth:20.2.0
+|    +--- androidx.fragment:fragment:1.0.0 -> 1.8.5 (*)
+|    +--- androidx.loader:loader:1.0.0 (*)
+|    +--- com.google.android.gms:play-services-auth-api-phone:18.0.1
+|    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
+|    |    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
+|    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
+|    +--- com.google.android.gms:play-services-auth-base:18.0.1
+|    |    +--- androidx.collection:collection:1.0.0 -> 1.4.0 (*)
+|    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
+|    |    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
+|    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
+|    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
+|    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
+|    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
-+--- org.wordpress:login:1.19.0
-|    +--- com.gravatar:gravatar:0.2.0
-|    |    +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
-|    |    +--- com.squareup.retrofit2:retrofit:2.9.0
-|    |    |    \--- com.squareup.okhttp3:okhttp:3.14.9 -> 4.12.0 (*)
-|    |    +--- com.squareup.retrofit2:converter-gson:2.9.0
-|    |    |    +--- com.squareup.retrofit2:retrofit:2.9.0 (*)
-|    |    |    \--- com.google.code.gson:gson:2.8.5 -> 2.10.1
-|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.3 -> 1.8.1 (*)
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.21 (*)
-|    +--- androidx.appcompat:appcompat:1.6.1 (*)
-|    +--- androidx.constraintlayout:constraintlayout:2.0.4 -> 2.1.4 (*)
-|    +--- com.google.android.material:material:1.2.1 -> 1.12.0 (*)
-|    +--- androidx.core:core:1.12.0 -> 1.13.1 (*)
-|    +--- com.github.bumptech.glide:glide:4.12.0 -> 4.16.0
-|    |    +--- com.github.bumptech.glide:gifdecoder:4.16.0
-|    |    |    \--- androidx.annotation:annotation:1.5.0 -> 1.8.1 (*)
-|    |    +--- com.github.bumptech.glide:disklrucache:4.16.0
-|    |    +--- com.github.bumptech.glide:annotations:4.16.0
-|    |    +--- androidx.fragment:fragment:1.3.6 -> 1.8.5 (*)
-|    |    +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
-|    |    +--- androidx.exifinterface:exifinterface:1.3.6 (*)
-|    |    \--- androidx.tracing:tracing:1.0.0 (*)
-|    +--- androidx.credentials:credentials:1.2.0
-|    |    +--- androidx.annotation:annotation:1.5.0 -> 1.8.1 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
-|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.1 -> 1.8.1 (*)
-|    |    \--- androidx.credentials:credentials-play-services-auth:1.2.0 (c)
-|    +--- androidx.credentials:credentials-play-services-auth:1.2.0
-|    |    +--- androidx.credentials:credentials:1.2.0 (*)
-|    |    +--- com.google.android.gms:play-services-auth:20.7.0 (*)
-|    |    +--- com.google.android.gms:play-services-fido:20.1.0 (*)
-|    |    +--- com.google.android.libraries.identity.googleid:googleid:1.1.0
-|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.0 -> 2.0.21 (*)
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
-|    |    \--- androidx.credentials:credentials:1.2.0 (c)
-|    +--- com.google.dagger:dagger:2.47 -> 2.51.1 (*)
-|    +--- com.google.dagger:dagger-android-support:2.47 -> 2.50
-|    |    +--- com.google.dagger:dagger:2.50 -> 2.51.1 (*)
-|    |    +--- com.google.dagger:dagger-android:2.50
-|    |    |    +--- com.google.dagger:dagger:2.50 -> 2.51.1 (*)
-|    |    |    +--- com.google.dagger:dagger-lint-aar:2.50
-|    |    |    +--- androidx.annotation:annotation:1.2.0 -> 1.8.1 (*)
-|    |    |    \--- javax.inject:javax.inject:1
-|    |    +--- com.google.dagger:dagger-lint-aar:2.50
-|    |    +--- androidx.activity:activity:1.5.1 -> 1.8.1 (*)
-|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.8.1 (*)
-|    |    +--- androidx.appcompat:appcompat:1.3.1 -> 1.6.1 (*)
-|    |    +--- androidx.fragment:fragment:1.5.1 -> 1.8.5 (*)
-|    |    +--- androidx.lifecycle:lifecycle-common:2.5.1 -> 2.8.7 (*)
-|    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 -> 2.8.7 (*)
-|    |    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 -> 2.8.7 (*)
-|    |    \--- javax.inject:javax.inject:1
-|    +--- com.google.android.gms:play-services-auth:18.1.0 -> 20.7.0 (*)
-|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.21 (*)
++--- org.wordpress:login:156-98aa2c6174009b24253133b6733be119b70b7178 FAILED
 +--- org.wordpress.aztec:glide-loader:v2.1.4
-|    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
+|    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0
+|         +--- com.github.bumptech.glide:gifdecoder:4.16.0
+|         |    \--- androidx.annotation:annotation:1.5.0 -> 1.8.1 (*)
+|         +--- com.github.bumptech.glide:disklrucache:4.16.0
+|         +--- com.github.bumptech.glide:annotations:4.16.0
+|         +--- androidx.fragment:fragment:1.3.6 -> 1.8.5 (*)
+|         +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
+|         +--- androidx.exifinterface:exifinterface:1.3.6 (*)
+|         \--- androidx.tracing:tracing:1.0.0 (*)
-+--- com.gravatar:gravatar:0.2.0 (*)
++--- com.gravatar:gravatar:0.2.0
+|    +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+|    +--- com.squareup.retrofit2:retrofit:2.9.0
+|    |    \--- com.squareup.okhttp3:okhttp:3.14.9 -> 4.12.0 (*)
+|    +--- com.squareup.retrofit2:converter-gson:2.9.0
+|    |    +--- com.squareup.retrofit2:retrofit:2.9.0 (*)
+|    |    \--- com.google.code.gson:gson:2.8.5 -> 2.10.1
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.3 -> 1.8.1 (*)
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.21 (*)
 +--- project :libs:cardreader
 |    \--- com.stripe:stripeterminal-localmobile:3.7.1
 |         +--- com.google.android.gms:play-services-safetynet:18.0.1
-|         |    \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
+|         |    \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
 |         \--- com.google.android.play:integrity:1.1.0
-|              \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|              \--- com.google.android.gms:play-services-basement:18.1.0 (*)
-+--- com.google.dagger:dagger-android-support:2.50 (*)
++--- com.google.dagger:dagger-android-support:2.50
+|    +--- com.google.dagger:dagger:2.50 -> 2.51.1 (*)
+|    +--- com.google.dagger:dagger-android:2.50
+|    |    +--- com.google.dagger:dagger:2.50 -> 2.51.1 (*)
+|    |    +--- com.google.dagger:dagger-lint-aar:2.50
+|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.8.1 (*)
+|    |    \--- javax.inject:javax.inject:1
+|    +--- com.google.dagger:dagger-lint-aar:2.50
+|    +--- androidx.activity:activity:1.5.1 -> 1.8.1 (*)
+|    +--- androidx.annotation:annotation:1.2.0 -> 1.8.1 (*)
+|    +--- androidx.appcompat:appcompat:1.3.1 -> 1.6.1 (*)
+|    +--- androidx.fragment:fragment:1.5.1 -> 1.8.5 (*)
+|    +--- androidx.lifecycle:lifecycle-common:2.5.1 -> 2.8.7 (*)
+|    +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 -> 2.8.7 (*)
+|    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 -> 2.8.7 (*)
+|    \--- javax.inject:javax.inject:1
 +--- com.google.android.play:app-update:2.1.0
-|    \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 +--- com.google.android.play:review:2.0.1
-|    \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 +--- com.google.android.gms:play-services-code-scanner:16.1.0
-|    +--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    +--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    \--- com.google.mlkit:barcode-scanning-common:17.0.0
-|         +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
+|         +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
 |         \--- com.google.mlkit:vision-common:17.0.0 -> 17.3.0
-|              +--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|              +--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |              \--- com.google.mlkit:common:18.6.0 -> 18.9.0
-|                   \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|                   \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 +--- com.google.mlkit:text-recognition:16.0.0
-|    +--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    +--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    +--- com.google.android.gms:play-services-mlkit-text-recognition:19.0.0
-|    |    +--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |    +--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    |    \--- com.google.android.gms:play-services-mlkit-text-recognition-common:19.0.0
-|    |         +--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |         +--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    |         \--- com.google.mlkit:vision-interfaces:16.2.0
-|    |              \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |              \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    \--- com.google.mlkit:text-recognition-bundled-common:16.0.0
-|         \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|         \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 +--- com.google.android.gms:play-services-mlkit-text-recognition-japanese:16.0.0
-|    \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 +--- com.google.android.gms:play-services-mlkit-text-recognition-chinese:16.0.0
-|    \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 +--- com.google.android.gms:play-services-mlkit-text-recognition-korean:16.0.0
-|    \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 +--- com.google.mlkit:barcode-scanning:17.2.0
-|    +--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    +--- com.google.android.gms:play-services-basement:18.1.0 (*)
 |    \--- com.google.android.gms:play-services-mlkit-barcode-scanning:18.3.0
-|         \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|         \--- com.google.android.gms:play-services-basement:18.1.0 (*)
 \--- com.google.android.gms:play-services-wearable:18.1.0
-     \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
+     \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)

wpmobilebot · 2025-01-16T15:44:53Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`abaa28a`
	Direct Download	`woocommerce-wear-prototype-build-pr13335-abaa28a.apk`

hichamboushaba · 2025-01-17T10:00:59Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/login/LoginActivity.kt

-    private fun showEmailPasswordScreen(
-        email: String?,
-        verifyEmail: Boolean,
-        password: String? = null


This part about prefilling the password was used just for the account signup, given we don't support this anymore, I deleted it, and deleted its code from the Fragment as well.

wpmobilebot · 2025-01-17T10:19:56Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`5c7bbc9`
	Direct Download	`woocommerce-prototype-build-pr13335-5c7bbc9.apk`

.../src/main/kotlin/com/woocommerce/android/ui/login/overrides/WooLoginEmailPasswordFragment.kt

irfano

It works as expected. LGTM! 👍🏻

…picious-emails [Login] Use Magic Link for suspicious emails [Part 2]

# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/login/LoginActivity.kt

codecov-commenter · 2025-01-21T12:29:07Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.17%. Comparing base (c15c17d) to head (d09a31e).
Report is 14 commits behind head on trunk.

Additional details and impacted files

@@            Coverage Diff            @@
##              trunk   #13335   +/-   ##
=========================================
  Coverage     41.16%   41.17%           
  Complexity     6440     6440           
=========================================
  Files          1323     1323           
  Lines         77246    77247    +1     
  Branches      10669    10669           
=========================================
+ Hits          31802    31804    +2     
+ Misses        42616    42615    -1     
  Partials       2828     2828

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hichamboushaba added 3 commits January 16, 2025 16:39

Bump login library version

fa6ccea

Update login listener override

3dcfa9d

Remove unused code and simplify logic

5c7bbc9

hichamboushaba added type: enhancement A request for an enhancement. status: do not merge Dependent on another PR, ready for review but not ready for merge. feature: login Related to any part of the log in or sign in flow, or authentication. labels Jan 16, 2025

hichamboushaba mentioned this pull request Jan 16, 2025

Use Magic Link for WordPress.com suspicious emails wordpress-mobile/WordPress-Login-Flow-Android#156

Merged

hichamboushaba commented Jan 17, 2025

View reviewed changes

hichamboushaba requested review from irfano, JorgeMucientes and hafizrahman and removed request for irfano and JorgeMucientes January 17, 2025 10:02

hichamboushaba marked this pull request as ready for review January 17, 2025 10:02

hichamboushaba added 4 commits January 17, 2025 15:56

Update listener overrides

09bde2b

Update the magic link sent screen

c4e056c

Bump login library

f797539

Add tracking

4621b77

irfano self-assigned this Jan 17, 2025

irfano reviewed Jan 18, 2025

View reviewed changes

.../src/main/kotlin/com/woocommerce/android/ui/login/overrides/WooLoginEmailPasswordFragment.kt Show resolved Hide resolved

irfano approved these changes Jan 18, 2025

View reviewed changes

hichamboushaba added 3 commits January 20, 2025 12:10

Fix UI tests compilation

36036da

Track username/password button click

3587e1e

Add a release note

15ce623

hichamboushaba added 2 commits January 21, 2025 10:58

Bump login version

183bee9

Merge pull request #13345 from woocommerce/issue/13341-magic-link-sus…

abaa28a

…picious-emails [Login] Use Magic Link for suspicious emails [Part 2]

hichamboushaba requested a review from a team as a code owner January 21, 2025 09:58

hichamboushaba removed the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Jan 21, 2025

Merge branch 'trunk' into issue/13321-magic-link-suspicious-emails

d09a31e

# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/login/LoginActivity.kt

hichamboushaba enabled auto-merge January 21, 2025 11:04

hichamboushaba added status: do not merge Dependent on another PR, ready for review but not ready for merge. and removed status: do not merge Dependent on another PR, ready for review but not ready for merge. labels Jan 21, 2025

hichamboushaba disabled auto-merge January 21, 2025 12:53

hichamboushaba merged commit 4478798 into trunk Jan 21, 2025
8 of 10 checks passed

hichamboushaba deleted the issue/13321-magic-link-suspicious-emails branch January 21, 2025 12:53

hichamboushaba linked an issue Jan 21, 2025 that may be closed by this pull request

Login: show Magic Link request screen when receiving the email_login_not_allowed error. #13331

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Login] Show magic link screen for suspicious emails #13335

[Login] Show magic link screen for suspicious emails #13335

hichamboushaba commented Jan 16, 2025 •

edited

Loading

dangermattic commented Jan 16, 2025 •

edited

Loading

wpmobilebot commented Jan 16, 2025

wpmobilebot commented Jan 16, 2025 •

edited

Loading

hichamboushaba Jan 17, 2025

wpmobilebot commented Jan 17, 2025

irfano left a comment

codecov-commenter commented Jan 21, 2025 •

edited

Loading

[Login] Show magic link screen for suspicious emails #13335

[Login] Show magic link screen for suspicious emails #13335

Conversation

hichamboushaba commented Jan 16, 2025 • edited Loading

Description

Steps to reproduce

Testing information

The tests that have been performed

Images/gif

Reviewer (or Author, in the case of optional code reviews):

dangermattic commented Jan 16, 2025 • edited Loading

wpmobilebot commented Jan 16, 2025

Project dependencies changes

wpmobilebot commented Jan 16, 2025 • edited Loading

hichamboushaba Jan 17, 2025

Choose a reason for hiding this comment

wpmobilebot commented Jan 17, 2025

irfano left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jan 21, 2025 • edited Loading

Codecov Report

hichamboushaba commented Jan 16, 2025 •

edited

Loading

dangermattic commented Jan 16, 2025 •

edited

Loading

wpmobilebot commented Jan 16, 2025 •

edited

Loading

codecov-commenter commented Jan 21, 2025 •

edited

Loading