Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wear App] Update Wear app with Play Store review rejection requests #12634

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

ThomazFB
Copy link
Contributor

@ThomazFB ThomazFB commented Sep 17, 2024

Summary

Brings to trunk the changes made to the Wear app to go through the recent Play Store rejection spree.

The changes are:

  • Update the app's splash screen icon
  • Update the app's splash screen background color
  • Add a configChanges attributes for the Main Activity in AndroidManifest to avoid issues with the NavController reference
  • Updates the Login error screen string to avoid UI clipping

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 18, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit51731ee
Direct Downloadwoocommerce-wear-prototype-build-pr12634-51731ee.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 18, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit51731ee
Direct Downloadwoocommerce-prototype-build-pr12634-51731ee.apk

@ThomazFB ThomazFB added type: task An internally driven task. feature: android wear labels Sep 19, 2024
@ThomazFB ThomazFB added this to the 20.5 milestone Sep 19, 2024
@ThomazFB ThomazFB marked this pull request as ready for review September 19, 2024 23:34
@ThomazFB ThomazFB merged commit 4cbfa75 into trunk Sep 19, 2024
18 checks passed
@ThomazFB ThomazFB deleted the issue/update-wear-with-play-store-review-changes branch September 19, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: android wear type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants