Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag for non-simple product types project #12811

Merged

Conversation

AnirudhBhat
Copy link
Contributor

Closes: #12807

Description

This PR adds a feature flag so that we could remove the "Simple" products filter for the products api and start showing all different product types for POS. This would help us in development of supporting Variable products for POS.

Testing information

Unit tests have been added to ensure this change doesn't break anything.

The tests that have been performed

  1. Unit tests for testing that both enabling and disabling the feature flag works as expected.
  2. Create a release build and ensure you don't see Variable products on POS. In other words, you should only see Simple products only on POS.
  3. Create a Debug build and ensure you see all products on POS.
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@AnirudhBhat AnirudhBhat added type: task An internally driven task. feature: point of sale POS project labels Oct 23, 2024
@AnirudhBhat AnirudhBhat added this to the 21.0 milestone Oct 23, 2024
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit6a260b9
Direct Downloadwoocommerce-wear-prototype-build-pr12811-6a260b9.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit6a260b9
Direct Downloadwoocommerce-prototype-build-pr12811-6a260b9.apk

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 40.86%. Comparing base (e1ef2aa) to head (6a260b9).
Report is 121 commits behind head on trunk.

Files with missing lines Patch % Lines
...pos/featureflags/IsNonSimpleProductTypesEnabled.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #12811   +/-   ##
=========================================
  Coverage     40.86%   40.86%           
  Complexity     5765     5765           
=========================================
  Files          1237     1238    +1     
  Lines         69857    69864    +7     
  Branches       9707     9708    +1     
=========================================
+ Hits          28545    28550    +5     
- Misses        38677    38679    +2     
  Partials       2635     2635           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnirudhBhat AnirudhBhat modified the milestones: 21.0, 21.1 Oct 28, 2024
@samiuelson samiuelson self-assigned this Oct 29, 2024
@AnirudhBhat AnirudhBhat added the status: feature-flagged Behind a feature flag. Milestone is not strongly held. label Oct 30, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 21.1. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

Copy link
Contributor

@samiuelson samiuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samiuelson samiuelson merged commit 9c96e74 into trunk Oct 30, 2024
18 of 21 checks passed
@samiuelson samiuelson deleted the issue/12807-support-for-variable-products-feature-flag branch October 30, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: point of sale POS project status: feature-flagged Behind a feature flag. Milestone is not strongly held. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Woo POS] Add feature flag for supporting non-simple products project
5 participants