-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature flag for non-simple product types project #12811
Add feature flag for non-simple product types project #12811
Conversation
… unit testing purpose
… for POS products
…r POS when the feature flag is disabled.
…d for POS when the feature flag is enabled.
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #12811 +/- ##
=========================================
Coverage 40.86% 40.86%
Complexity 5765 5765
=========================================
Files 1237 1238 +1
Lines 69857 69864 +7
Branches 9707 9708 +1
=========================================
+ Hits 28545 28550 +5
- Misses 38677 38679 +2
Partials 2635 2635 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes: #12807
Description
This PR adds a feature flag so that we could remove the "Simple" products filter for the products api and start showing all different product types for POS. This would help us in development of supporting Variable products for POS.
Testing information
Unit tests have been added to ensure this change doesn't break anything.
The tests that have been performed
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: