Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating shipping label: Total card #12831

Merged
merged 6 commits into from
Oct 25, 2024
Merged

Creating shipping label: Total card #12831

merged 6 commits into from
Oct 25, 2024

Conversation

atorresveiga
Copy link
Contributor

@atorresveiga atorresveiga commented Oct 25, 2024 •
edited
Loading

Part of: #12281

Description

This PR includes the total card implementation and some margin adjustments. Its changes are focused on UI, and the data used in the screens is mocked. I will connect this UI with real data in a different PR.

Testing information

  1. Create an Order with the processing status on a store that can create shipping labels
  2. Tap on Orders
  3. Tap on the order created on step 1
  4. Tap con create shipping labels
  5. Check that Shipment details card is displayed at the bottom of the screen
  6. Tap on/Drag up Shipment details
  7. Check that the bottom sheets expand and the Address card is visible

The tests that have been performed

  1. Test that the UI interaction works as expected

Images/gif

Before After
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@atorresveiga atorresveiga added type: task An internally driven task. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Oct 25, 2024
@atorresveiga atorresveiga added this to the 21.0 milestone Oct 25, 2024
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit849d6ba
Direct Downloadwoocommerce-wear-prototype-build-pr12831-849d6ba.apk

@atorresveiga atorresveiga modified the milestones: 21.0, 21.1 Oct 25, 2024
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit849d6ba
Direct Downloadwoocommerce-prototype-build-pr12831-849d6ba.apk

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 25, 2024
View reviewed changes
WooCommerce/src/main/res/drawable/ic_shipping_label_items.xml
android:viewportWidth="20"
android:viewportHeight="19">
<path
android:pathData="M4.771,18.163C3.872,18.163 3.186,17.931 2.712,17.467C2.244,17.008 2.009,16.329 2.009,15.431V5.316H3.306V15.482C3.306,16.454 3.794,16.939 4.771,16.939H15.222C15.686,16.939 16.045,16.815 16.299,16.566C16.553,16.317 16.68,15.955 16.68,15.482V5.316H17.983V15.431C17.983,16.329 17.747,17.008 17.273,17.467C16.804,17.931 16.118,18.163 15.215,18.163H4.771ZM6.836,9.688C6.65,9.688 6.499,9.63 6.382,9.513C6.27,9.395 6.213,9.239 6.213,9.044V8.758C6.213,8.563 6.27,8.409 6.382,8.297C6.499,8.18 6.65,8.121 6.836,8.121H13.157C13.347,8.121 13.498,8.18 13.611,8.297C13.728,8.409 13.787,8.563 13.787,8.758V9.044C13.787,9.239 13.728,9.395 13.611,9.513C13.498,9.63 13.347,9.688 13.157,9.688H6.836ZM2.317,5.909C1.775,5.909 1.357,5.75 1.064,5.433C0.776,5.116 0.632,4.688 0.632,4.151V2.708C0.632,2.352 0.701,2.042 0.837,1.778C0.974,1.515 1.167,1.312 1.416,1.17C1.67,1.024 1.97,0.951 2.317,0.951H17.676C18.218,0.951 18.633,1.109 18.921,1.427C19.214,1.744 19.36,2.171 19.36,2.708V4.151C19.36,4.688 19.214,5.116 18.921,5.433C18.633,5.75 18.218,5.909 17.676,5.909H2.317ZM2.617,4.686H17.383C17.622,4.686 17.795,4.63 17.903,4.518C18.01,4.4 18.064,4.22 18.064,3.976V2.877C18.064,2.638 18.01,2.462 17.903,2.35C17.795,2.232 17.622,2.174 17.383,2.174H2.617C2.378,2.174 2.202,2.232 2.09,2.35C1.982,2.462 1.929,2.638 1.929,2.877V3.976C1.929,4.22 1.982,4.4 2.09,4.518C2.202,4.63 2.378,4.686 2.617,4.686Z"

Check warning

Code scanning / Android Lint

Long vector paths Warning

Very long vector path (1369 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.
WooCommerce/src/main/res/drawable/ic_shipping_label_shipping_line.xml Dismissed Show dismissed Hide dismissed
@atorresveiga atorresveiga merged commit e70d3fc into trunk Oct 25, 2024
18 of 19 checks passed
@atorresveiga atorresveiga deleted the issue/12281-creating-shipping-label-total-card branch October 25, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task.
Projects
None yet
Milestone
21.1
Development

Successfully merging this pull request may close these issues.
2 participants
@atorresveiga @wpmobilebot