-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Login] Remove dependency on XMLRPC for the Account Mismatch flow #13308
[Login] Remove dependency on XMLRPC for the Account Mismatch flow #13308
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
7155f5b
to
72481db
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13308 +/- ##
============================================
+ Coverage 41.10% 41.15% +0.05%
- Complexity 6421 6429 +8
============================================
Files 1321 1321
Lines 77177 77135 -42
Branches 10643 10640 -3
============================================
+ Hits 31722 31744 +22
+ Misses 42646 42572 -74
- Partials 2809 2819 +10 ☔ View full report in Codecov by Sentry. |
@hichamboushaba, I couldn't test the case because I seem to be missing something. Can you help me figure out what I’m overlooking?
I'm a bit confused here. |
Thanks for the review @irfano, when you say failed, what do you mean? A screen recording and app logs would be great to understand the issue. |
I guess I was using the wrong password. I was able to reproduce the issue on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn’t familiar with this area of the app, so it took some time. Looks good to me! 👍🏻
Closes: #3974
Description
This PR updates the Account Mismatch flow to not depend on XMLRPC anymore, it uses now Cookies+Nonce authentication for fetching the email of the Jetpack User to continue with authentication or connection.
(We might want to unify this Jetpack setup logic with the other one in the
JetpackActivation...
screens, as it's almost the same, but for now this does the job)Steps to reproduce
(Following the above on
trunk
will fail, but won't crash the app, the crash of the linked issue is caused by some other XMLRPC issues, but given we don't use XMLRPC anymore, we fix the crash as well)Testing information
The tests that have been performed
Images/gif
Screen_recording_20250114_175907.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: