[Gradle] Update Build Scans Config (Develocity)
#13343
Merged
+21
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This configuration was based on 'measureBuildsEnabled' and only used alongside the 'buildScan' configuration. However, after discussing about it, it was decided that this Gradle build scans should only run on CI by default and not locally (at least for the time being).
This configuration had meaning alongside the 'userEnabledTracking' related 'buildScan' configuration, which is not removed. After discussing about it, it was decided that this Gradle build scans should only run on CI by default and not locally (at least for the time being). FYI: This change effectively reverts this 4495d24 and this 7ebcc9b commits.
Release Notes: https://plugins.gradle.org/plugin/ com.gradle.develocity/3.19 FYI: With this update, and annoyingly, you need to manually accept the terms at the end of each build for the build scan to get published.
For more info see: - Connecting to scans.gradle.com: https://docs.gradle.com/develocity/ gradle-plugin/current/#connecting_to_scans_gradle_com - Using Build Scans: https://docs.gradle.com/develocity/ gradle-plugin/current/#using_build_scans
For more info see: - Publishing every build: https://docs.gradle.com/develocity/ gradle-plugin/current/#controlling_when_build_scans_are_published
Previously, it wasn't possible to apply this 'gradle_build_scan.gradle'
file from the 'settings.gradle' file, but now, after the Develocity
migration, it seems that it is now perfectly possible, most probably
because of the added 'develocity { ... }' block.
As discussed this feature wasn't very useful, not used once, and it is planned to be removed.
ParaskP7
added
category: tooling
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
wzieba
approved these changes
Jan 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #13343 +/- ##
============================================
- Coverage 41.14% 41.14% -0.01%
+ Complexity 6432 6431 -1
============================================
Files 1322 1322
Lines 77207 77207
Branches 10657 10657
============================================
- Hits 31766 31765 -1
Misses 42617 42617
- Partials 2824 2825 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check Also: JP/WPAndroid#21234
Description
This PR updates build scans configuration for this project. Also, it updates from
com.gradle.enterprisepointing to3.17.2into the latestcom.gradle.develocityversion (3.19). 🏗️The main goal of this PR is to make the
buildScanrelated configuration consistent with the rest of the projects (as discussed: p1737118736712299/1737108520.561709-slack-C030U03RC8Y). As such, the main changes that is happening here are:userEnabledTrackingconfiguration is removed. No more havingbuildScanrunning by default locally for (at least) internal developers. (965aff3)obfuscationconfiguration is removed. Now thatbuildScanis not running locally by default, this is not really needed. (b218109)com.gradle.enterpriseupdated tocom.gradle.develocityversion (3.19). (71a97f2)attachGradleScanIdis being disabled. This feature wasn't very useful, not used once, and it isplanned to be removed. (140fa3f)
Note
Unrelated to anything Gradle build scans, but as part of this 15ab1cf change I noticed that both, the includeSourceContext & autoUploadSourceContext are
true(for both theMobileandWearapp). However, when comparing that configuration to how JP/WPAndroid is configured, I noticed that the same configuration is based on theisCIflag (see includeSourceContext & includeProguardMapping). My question being, shouldn't we depend on theisCIflag for this project as well? 🤔Testing information
localbuilds:gradlewtask (ie.assembleJalapenoDebug) and notice that, at the very end, there is no build scan publishing happening.gradlewtask (ie.assembleJalapenoDebug) with--scanand make sure that issuing a build scan on demand works as expected.cibuilds:gradle.com/s/xyzlink is available for that build job/task (example Prototype Build -> Build Scan).PS: Just because of this 71a97f2 commit, which updates to 3.19, you would also want to verify that everything is still working as expected with
build cache:Prototype Build -> Build Scan -> Performance [Build Cache] -> Check
Remote cache -> Configuration -> URL& Any Other ConfigurationsRELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: