-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Login] Use Magic Link for suspicious emails [Part 2] #13345
[Login] Use Magic Link for suspicious emails [Part 2] #13345
Conversation
Generated by 🚫 Danger |
Project dependencies changesThe following changes in project dependencies were detected (configuration list
tree-\--- org.wordpress:login:156-98aa2c6174009b24253133b6733be119b70b7178
+\--- org.wordpress:login:157-2b5183bb47cd6f53738862849e31c4efcad52ed0 |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
557c816
to
4621b77
Compare
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM since I already tested it on the other PR wordpress-mobile/WordPress-Login-Flow-Android#157
Code looks good, nice details with updating Java-style var names too.
abaa28a
into
issue/13321-magic-link-suspicious-emails
Closes: #13341
Depends on wordpress-mobile/WordPress-Login-Flow-Android#157
Description
This PR updates the login library to bring the changes of the above PR, which updates the Magic Link screens to show a correct button when used in the suspicious email flow.
The PR also updates our current
LoginMagicLinkSentImprovedFragment
with the same changes.Steps to reproduce
Testing information
woocommerceandroid_unified_login_interaction, Properties:{"flow":"login_magic_link", "step":"start", "click":"login_with_wp_com_username_password"}
The tests that have been performed
^
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: