-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Receipts] IO Exception crash #13411
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
return interceptAndModifyReceiptResponse(request) | ||
} | ||
): WebResourceResponse? = | ||
if (request.url.toString() == urlToLoad) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is to modify the response only on the root page. Otherwise, we change mimeType for all the page resources which externally placed (icons, css, js)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. LGTM
This is just an update that the changes introduced here are published as a beta through the version |
Closes: #13410
Description
We are crashing on IOException when loading a receipt. The PR logs the case and return null which means keep loading
Steps to reproduce
openConnection
The tests that have been performed
Above
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: