[Store Customization] Flush permalinks after updating all products (#…

…11971) * Flush after updating all products, not after updating each of the products Flushing is an expensive operation so we should run it carefully * Remove the index param and add the last_product param to the Product endpoint. --------- Co-authored-by: Patricia Hillebrandt <[email protected]>
woocommerce · Dec 1, 2023 · 4962e59 · 4962e59
1 parent 664c56f
commit 4962e59
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/src/Patterns/ProductUpdater.php b/src/Patterns/ProductUpdater.php
@@ -260,7 +260,6 @@ public function update_product_content( $ai_generated_product_content ) {
 				),
 			)
 		);
-		flush_rewrite_rules();
 
 		require_once ABSPATH . 'wp-admin/includes/media.php';
 		require_once ABSPATH . 'wp-admin/includes/file.php';

diff --git a/src/StoreApi/Routes/V1/AI/Product.php b/src/StoreApi/Routes/V1/AI/Product.php
@@ -46,14 +46,14 @@ public function get_args() {
 				'callback'            => [ $this, 'get_response' ],
 				'permission_callback' => [ Middleware::class, 'is_authorized' ],
 				'args'                => [
-					'index'                => [
-						'description' => __( 'The business description for a given store.', 'woo-gutenberg-products-block' ),
-						'type'        => 'integer',
-					],
 					'products_information' => [
 						'description' => __( 'Data generated by AI for updating dummy products.', 'woo-gutenberg-products-block' ),
 						'type'        => 'object',
 					],
+					'last_product'         => [
+						'description' => __( 'Whether the product being updated is the last one in the loop', 'woo-gutenberg-products-block' ),
+						'type'        => 'boolean',
+					],
 				],
 			],
 			'schema'      => [ $this->schema, 'get_public_item_schema' ],
@@ -82,6 +82,12 @@ protected function get_route_post_response( \WP_REST_Request $request ) {
 
 		$product_updater->update_product_content( $product_information );
 
+		$last_product_to_update = $request['last_product'] ?? false;
+
+		if ( $last_product_to_update ) {
+			flush_rewrite_rules();
+		}
+
 		return rest_ensure_response(
 			array(
 				'ai_content_generated' => true,
-Original file line number
+Diff line change
@@ Expand Up @@
     				),
     			)
     		);
-    		flush_rewrite_rules();
     		require_once ABSPATH . 'wp-admin/includes/media.php';
     		require_once ABSPATH . 'wp-admin/includes/file.php';
@@ Expand Down @@