This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Investigate E2E CI caching issue #11874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
tarunvijwani
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +7 B (0%) Total Size: 1.61 MB
ℹ️ View Unchanged
|
nielslange
added
type: refactor
nielslange
force-pushed
the
fix/11819-investigate-E2E-CI-caching-issue
branch
3 times, most recently
from
f0d625a to
d13261d
Compare
nielslange
added
the
skip-changelog
tarhi-saad
suggested changes
Nov 24, 2023
There was a problem hiding this comment.
Thank you for working on this PR, @nielslange! The main issue is fixed. I added some comments below regarding the unskipped tests.
tests/e2e/tests/templates/checkout-template.block_theme.spec.ts
Outdated
Show resolved
Hide resolved
tarhi-saad
suggested changes
Nov 24, 2023
There was a problem hiding this comment.
@nielslange, could you fix the TS errors if the function admin.visitSiteEditor() in the Cart and Checkout templates. These errors were introduced in #11866.
nielslange
force-pushed
the
fix/11819-investigate-E2E-CI-caching-issue
branch
from
21a7474 to
6ce0e0a
Compare
nielslange
force-pushed
the
fix/11819-investigate-E2E-CI-caching-issue
branch
from
7c9105e to
8e22619
Compare
|
Thanks for your review, @tarhi-saad. I've address all your feedback and ensured that the tests are still passing. You can do another review now. |
tarhi-saad
approved these changes
Nov 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11819
Fixes #11820
Why
In this PR, we address issues identified after our recent changes to the Page: Cart and Page: Checkout templates. Previously, in #11029, we updated these pages' heading levels from h2 to h1, and in #11709, we adjusted our E2E tests to align with these changes. However, we observed that the adjusted E2E tests were failing. Upon investigation, we identified the following problems:
Template optionsbutton had been changed.This PR aims to resolve these issues, ensuring that our E2E tests reflect the latest template modifications.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
n/a
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog
n/a