This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Enable new notice styles for all themes #12043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslange
added
type: enhancement
woocommercebot
requested review from
a team and
tarunvijwani
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +24 B (0%) Total Size: 1.61 MB
ℹ️ View Unchanged
|
tarunvijwani
reviewed
Dec 5, 2023
Good catch, @tarunvijwani. This issue might be related to the test code snippet. When the notices triggered during the checkout flow, the icons are visible: 
Test stepsYou should be able to see the icons by executing the following steps:
|
This was referenced Dec 12, 2023
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Display new notice styles for the shortcode-based cart and checkout.
Fixes #12042
Why
In #8659, @mikejolley updated the shopper notice styles. Until now, these styles were only visible when the store was using the Cart or the Checkout block. This PR ensures that the new styles are now applied universally, regardless of whether the store uses a Cart or Checkout block.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
/wp-admin/admin.php?page=wc-settings&tab=advancedand verify that no Cart page or Checkout page is selected:Tip
Optional: Install and activate the SMNTCS Themes List View plugin to easily switch between installed themes.
Important
Please note that when using the Twenty Twelve and Twenty Twenty themes the indentation for the error message list items needs to be adjusted. This fix will take place in https://github.com/woocommerce/woocommerce.
Screenshots or screencast
Twenty Twenty-One
Twenty Twenty
Twenty Nineteen
Twenty Seventeen
Twenty Sixteen
Twenty Fifteen
Twenty Fourteen
Twenty Thirteen
Twenty Twelve
Twenty Eleven
Twenty Ten
Cross-browser compatibility
WooCommerce Visibility
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog