This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix font weight of cart totals title in site editor #12051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslange
added
type: bug
woocommercebot
requested review from
a team and
tarhi-saad
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +65 B (0%) Total Size: 1.61 MB
ℹ️ View Unchanged
|
tarhi-saad
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Thanks for the PR, @nielslange – it looks great! 👍 I have just a small suggestion. Since the font-weight: bold; for the th element is determined by the browser's user agent, wouldn't it be safer for us to override this style ourselves? This could ensure consistency, particularly if different browsers apply varying font-weight values.
Thanks for reaching out, @tarhi-saad. Can you clarify what you mean by "Since the |
@nielslange, the default styles of HTML elements (e.g., |
Thanks for clarifying this, @tarhi-saad. To be consistent with the other elements, I've applied |
|
The changes look good, @nielslange! Let's 🚢 it! |
nielslange
force-pushed
the
fix/11870-font-weights-in-TT4
branch
from
9bdd5c6 to
f9910b5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11870
Why
In #11870, @ralucaStan reported that when viewing the Cart block in the site editor, the title
Cart totalsis using a different font weight than the titlesProductandTotal.The reason behind that is that the titles
ProductandTotalare displayed in a<th>element. By default, the<th>element is usingfont-weight: boldwhich translates tofont-weight: 700, see https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight#syntax.The
Cart totalstitle, however, is a<textarea>to enable merchants to customise the text of this title. By default, the<textarea>element is usingfont-weight: normalwhich translates tofont-weight: 400.In the initial report (#11870), the issue was observed in the Twenty Twenty-Four theme. Upon further investigation, I noticed that this issue not only affected the Twenty Twenty-Four theme, but all block themes, including Twenty Twenty-Three and Twenty Twenty-Two. This broader impact was due to the nature of the issue.
I also noticed that in the frontend, the title
Cart totalswas usingfont-weight: 600. To ensure a consistent font weight, this PR changes the corresponding definition tofont-weight: 700.Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
/wp-admin/site-editor.php?path=%2Fpageand open the Cart page.Product,TotalandCart totalsare usingfont-weight: boldresp.font-weight: 700./wp-admin/site-editor.php?path=%2Fwp_template.Screenshots or screencast
Site editor
Frontend
Cross-browser compatibility
WooCommerce Visibility
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog