Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACH payment processing with saved bank accounts #3811

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

rafaelzaleski
Copy link
Contributor

@rafaelzaleski rafaelzaleski commented Jan 30, 2025

Closes #3787

Changes proposed in this Pull Request:

  • Make ACH reusable and introduce tokenization.
  • Enhance unit test coverage for ACH.

Testing instructions

Test 1: Add, Remove and Mark the token as default in the my account page.

  1. Log in as a customer.
  2. Go to My Account > Payment methods.
  3. Add a new payment method and select “ACH Direct Debit”
  4. After successfully adding the ACH payment method, verify it shows up under Payment methods.
  5. Remove the ACH payment method by clicking “Delete” and confirm the token is removed.
  6. Add the ACH payment method again and a credit card payment option, then mark ACH as default by selecting “Make default.” Confirm it is set as the default payment method.

Test 2: Save the token at checkout, and use the saved token in a subsequent purchase.

  1. Add a product to your cart and proceed to checkout.
  2. In the Payment section, choose “ACH Direct Debit.”
  • Ensure there’s an option like “Save this payment method”, select it.
  1. Enter the required bank details (test routing and account numbers) and complete the checkout.
  2. After the order is placed, verify the order confirmation and note that a new ACH token should be created for your account.
  3. Start a new purchase (add another product to cart).
  4. At checkout, select the saved ACH token.
  5. Complete checkout without having to re-enter bank account details. Confirm the purchase is successful and uses the existing ACH token.
  6. Repeat for the shortcode and blocks checkout.
  7. Go to My Account > Payment methods and confirm the tokens created in this test are present.

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@rafaelzaleski rafaelzaleski marked this pull request as ready for review February 7, 2025 14:04
@rafaelzaleski rafaelzaleski self-assigned this Feb 7, 2025
@rafaelzaleski rafaelzaleski requested review from a team and asumaran and removed request for a team February 7, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACH: Process Payment with a Saved Payment Method
1 participant