Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing saving of Bancontact tokens as SEPA tokens #3816

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Jan 31, 2025

Fixes #3776

Changes proposed in this Pull Request:

iDEAL and Bancontact tokens are stored as SEPA tokens. Because of that, when SEPA is disabled, it is not possible to add or list saved iDEAL and Bancontact methods.

This PR adds SEPA to the list of valid payment method tokens when listing saved methods to fix the issue.

Testing instructions

  • Checkout and build this branch on your test environment (add/bancontact-saved-method-as-sepa)
  • Connect your Stripe account
  • Set your store currency to EUR
  • Enable the Bancontact payment method in settings (wp-admin/admin.php?page=wc-settings&tab=checkout&section=stripe&panel=methods). Keep SEPA disabled
  • As a shopper, go to the Add Payment Method page (my-account/add-payment-method/)
  • Try to add a new Bancontact method
  • Confirm that the payment method is saved and is correctly listed:
Screenshot 2025-01-31 at 14 29 40
  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@wjrosa wjrosa self-assigned this Jan 31, 2025
@wjrosa wjrosa marked this pull request as ready for review January 31, 2025 17:29
@wjrosa wjrosa requested review from a team and annemirasol and removed request for a team January 31, 2025 17:53
Copy link
Contributor

@annemirasol annemirasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I was able to save and use Bancontact tokens even when SEPA was not explicitly enabled.

@wjrosa wjrosa merged commit 081f070 into develop Feb 3, 2025
36 of 37 checks passed
@wjrosa wjrosa deleted the add/bancontact-saved-method-as-sepa branch February 3, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save Bancontact payment tokens as SEPA Debit tokens
2 participants