Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to allow other methods to be saved as SEPA tokens #3819

Merged
merged 8 commits into from
Feb 3, 2025

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Jan 31, 2025

Fixes #3786

Changes proposed in this Pull Request:

This PR adds a new setting to allow merchants to control whether Bancontact and iDEAL payment methods can be saved for later purchases as SEPA Direct Debit tokens. Some merchants would avoid this behavior since the SEPA method takes too long to be identified (~8 business days).

Testing instructions

  • Checkout and build this branch on your test environment (add/sepa-tokens-for-other-methods-setting)
  • Connect your Stripe account
  • Set your store currency to EUR
  • Enable Bancontact and iDEAL
  • Confirm you are able to see the new setting and it is enabled by default:
Screenshot 2025-01-31 at 16 19 12
  • Confirm you can disable/enable the setting and that by reloading the page the change is persisted
  • As a shopper, with the setting enabled, try to add a new Bancontact method
  • Confirm the method is saved
Screenshot 2025-01-31 at 16 22 39
  • Disable the setting and confirm you are not able to save the method anymore
  • Repeat the test steps for iDEAL

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@wjrosa wjrosa self-assigned this Jan 31, 2025
@wjrosa wjrosa changed the base branch from develop to add/bancontact-saved-method-as-sepa January 31, 2025 18:46
@wjrosa wjrosa marked this pull request as ready for review January 31, 2025 18:46
@wjrosa wjrosa requested review from a team and annemirasol and removed request for a team January 31, 2025 19:24
Base automatically changed from add/bancontact-saved-method-as-sepa to develop February 3, 2025 12:53
@annemirasol
Copy link
Contributor

@wjrosa I noticed that even with the setting off, during checkout, it still asks me if I want to save my payment information:

Screenshot 2025-02-03 at 1 24 16 PM

Is that something want to hide, since it doesn't work anyways and might confuse the shopper?

@wjrosa
Copy link
Contributor Author

wjrosa commented Feb 3, 2025

@wjrosa I noticed that even with the setting off, during checkout, it still asks me if I want to save my payment information:

Screenshot 2025-02-03 at 1 24 16 PM Is that something want to hide, since it doesn't work anyways and might confuse the shopper?

@annemirasol sorry, I forgot to mention that I fixed this issue on the other PR #3821

Copy link
Contributor

@annemirasol annemirasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

✅ With the setting turned on, I am able to save, see and use Bancontact payment tokens.
✅ With the setting turned off, I am not able to see and use saved Bancontact payment tokens.

@wjrosa wjrosa enabled auto-merge (squash) February 3, 2025 20:57
@wjrosa wjrosa merged commit c2ba0fa into develop Feb 3, 2025
37 checks passed
@wjrosa wjrosa deleted the add/sepa-tokens-for-other-methods-setting branch February 3, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to toggle saving of iDEAL payment methods as SEPA tokens
2 participants