Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscriptions support to Bacs #3987

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

asumaran
Copy link
Contributor

@asumaran asumaran commented Feb 26, 2025

Closes #3798

Changes proposed in this Pull Request:

The changes here are quite simple. The most important one is enabling Bacs support for subscriptions. By default, Bacs should work well for the subscription cases listed below, except for subscriptions with a free trial. For now, the Bacs payment method is being disabled for subscriptions with a free trial as it will be addressed separately. More info here.

Testing instructions

Install the WooCommerce Subscriptions and test checking out using following subscription variatons.

  • Simple subscription.
    • Virtual product.
    • Physical product.
  • Variable subscription.
    • Virtual products.
    • Physical products.
  • Simple subscription with:
    • Free Trial
      {
        "error": {
          "message": "Your account isn't configured to directly use SetupIntents to create Mandates for Bacs Direct Debits. See https://stripe.com/docs/payments/payment-methods/bacs-debit to learn more, or contact us through https://support.stripe.com/contact/.",
          "param": "deferred_intent.payment_method_types",
          "request_log_url": "https://dashboard.stripe.com/acct_1Ja916HJAl4h87JO/test/logs/req_D2rNbNMZcnr08C?t=1740691770",
          "type": "invalid_request_error"
        }
      }
      
    • Sign Up Fee.
    • Free trial with Sign Up Fee

It would be nice to test with shortcode checkout and the checkout block.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

@asumaran asumaran force-pushed the as-bacs-subscription-support branch from dd423aa to fefa53c Compare February 27, 2025 18:34
@asumaran asumaran force-pushed the as-bacs-subscription-support branch from fefa53c to 8d63e1e Compare March 3, 2025 19:32
@asumaran asumaran marked this pull request as ready for review March 3, 2025 21:07
@asumaran asumaran requested review from a team and lovo-h and removed request for a team March 3, 2025 21:09
@asumaran asumaran self-assigned this Mar 3, 2025
@asumaran asumaran added the component: LPMs/APMs Issues related to LPMs/APMs label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: LPMs/APMs Issues related to LPMs/APMs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bacs: WooCommerce Subscriptions support
1 participant