Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Universal Analytics code #320

Merged
merged 12 commits into from
Oct 30, 2023

Conversation

martynmjones
Copy link
Contributor

@martynmjones martynmjones commented Oct 27, 2023

Changes proposed in this Pull Request:

Removes all existing Universal Analytics code from the extension.

Detailed test instructions:

  1. Review the changes and deleted code
  2. Run some very basic smoke tests to confirm no errors are triggered by the changes

Additional details:

In addition to removing the UA code, some tracking was moved from class-wc-google-analytics.php c566ea7 into class-wc-google-gtag-js.php 2ee2fad. The tracking itself doesn't need testing here as it will be completely reworked in a follow up PR.

Changelog entry

Remove - Universal Analytics code

@martynmjones martynmjones marked this pull request as ready for review October 27, 2023 11:13
@martynmjones martynmjones requested a review from a team October 27, 2023 11:25
@tomalec
Copy link
Member

tomalec commented Oct 27, 2023

As we removed the "Enhances e-Commerce" section, I think we should move its options to the main section (remove 'class' => 'enhanced-setting').
Currently, it seems like they are a part of "Cross Domain Tracking"
image

includes/class-wc-google-analytics.php Outdated Show resolved Hide resolved
includes/class-wc-google-gtag-js.php Outdated Show resolved Hide resolved
includes/class-wc-google-analytics.php Show resolved Hide resolved
includes/class-wc-google-analytics.php Show resolved Hide resolved
@martynmjones
Copy link
Contributor Author

Many thanks for the review @tomalec! I've addressed the questions and points you raised so this is ready for a second look 👀.

@martynmjones martynmjones requested a review from tomalec October 30, 2023 05:36
@martynmjones martynmjones self-assigned this Oct 30, 2023
@martynmjones martynmjones mentioned this pull request Oct 30, 2023
9 tasks
Copy link
Member

@tomalec tomalec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes and clarifications, LGTM

@martynmjones martynmjones merged commit a3d1ae9 into remove-universal-analytics Oct 30, 2023
6 checks passed
@martynmjones martynmjones deleted the remove/ua-code branch October 30, 2023 12:30
@jorgemd24 jorgemd24 mentioned this pull request Mar 5, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants