Update test environment setup to resolve notice #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog: fix
martynmjones
changed the title
tomalec
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
I reviewed the code, and re-run actions after updating to trunk
The notice previously visible in https://github.com/woocommerce/woocommerce-google-analytics-integration/actions/runs/7008481328/job/19064889224#step:5:199
is no longer there https://github.com/woocommerce/woocommerce-google-analytics-integration/actions/runs/7008485329/job/19064900231?pr=335#step:5:34
LGTM
This was referenced Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #334
Updates
UnitTestsBootstrapto runinstall_wcon theinithook to resolve the notice.Screenshots:
Detailed test instructions:
Additional
composer require --dev yoast/phpunit-polyfills:"^1.1.0" && composer installChangelog entry