Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the workflows in GitHub Actions to use Node.js v20 #423

Merged
merged 1 commit into from
May 17, 2024

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

This PR upgrades the workflows in GitHub Actions to use Node.js v20.

Checks:

  • Does your code follow the WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Detailed test instructions:

  1. View the Checks tab to check if all checks have passed and if there are no longer deprecated warnings about Node.js <= 16
  2. View the E2E Tests result that is not listed in the Checks tab
  3. The rest of workflows that can't be viewed in this PR have basically been verified during development, if one wants to view them, please find the corresponding development RP in Upgrade to Node.js v20 grow#108

Changelog entry

@eason9487 eason9487 added the changelog: dev Developer-facing only change. label May 16, 2024
@eason9487 eason9487 requested a review from a team May 16, 2024 10:55
@eason9487 eason9487 self-assigned this May 16, 2024
Copy link
Contributor

@puntope puntope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eason9487
Copy link
Member Author

Hi @puntope, thanks for the review.

Here I miss the Build WF (similar to woocommerce/automatewoo-birthdays#139 (comment))

and the Branch label assignation as reported here woocommerce/automatewoo-birthdays#139 (comment)

Please refer to https://github.com/woocommerce/automatewoo-birthdays/pull/139#issuecomment-2116918286

@eason9487 eason9487 requested a review from puntope May 17, 2024 07:29
@eason9487 eason9487 merged commit c0fff06 into trunk May 17, 2024
8 checks passed
@eason9487 eason9487 deleted the dev/upgrade-gha-workflows branch May 17, 2024 07:52
@martynmjones martynmjones mentioned this pull request Jun 5, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants