Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Xcode 15.4 #12910

Merged
merged 10 commits into from
Jun 7, 2024
Merged

Upgrade to Xcode 15.4 #12910

merged 10 commits into from
Jun 7, 2024

Conversation

soundsokay
Copy link
Contributor

@soundsokay soundsokay commented May 31, 2024 •
edited
Loading

Description

Now that Xcode 15.4 is supported in CI, this PR makes changes to bump up the current Xcode version to 15.4.

Steps to reproduce

N/A

Testing information

Using Xcode 15.4:

  • Check out the branch.
  • run rake dependencies
  • Clean build folder
  • Run the UI tests against an iPad Air simulator

Screenshots

N/A

@soundsokay soundsokay added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label May 31, 2024
@soundsokay soundsokay added this to the 19.0 milestone May 31, 2024
@soundsokay soundsokay added the type: task An internally driven task. label May 31, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 31, 2024 •
edited
Loading

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr12910-71dfd7e
Version18.9
Bundle IDcom.automattic.alpha.woocommerce
Commit71dfd7e
App Center BuildWooCommerce - Prototype Builds #9486
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@pmusolino
Copy link
Member

JFYI, I created a PR for updating the Tracks library here #12939 since there is also a fix to use Sentry 8.26.0 that is compatible with Xcode 15.4 Automattic/Automattic-Tracks-iOS#286

@soundsokay
tests: only allow test_site_address_login_logout UI test to run on iPad
704b1ad 
It fails locally and on CI when run against an iPhone SE simulator.
@soundsokay soundsokay requested a review from a team as a code owner June 4, 2024 22:47
soundsokay and others added 7 commits June 4, 2024 23:05
@soundsokay
test: only allow test_create_new_order UI test to run on iPad
8ad0a25 
It fails locally and on CI when run against an iPhone SE simulator.
@soundsokay
test: restrict three payments UI tests to only run on iPad
1e08123 
They fail locally and on CI when run against an iPhone SE simulator.
@soundsokay
test: only allow test_load_reviews_screen UI test to run on iPad
13d3b91 
It fails locally and on CI when run against an iPhone SE simulator.
@soundsokay
test: test: restrict three payments UI tests to only run on iPad, par…
bcf5f8c 
…t II

Do not execute test setup unless on iPad.
@jkmassel
Specify correct test device
9a4148b
@jkmassel
Test on all devices
73cdfe4
@jkmassel
Use the right device for UI tests (#12973)
71dfd7e
@soundsokay soundsokay modified the milestones: 19.0, 19.1 Jun 6, 2024
@soundsokay
Copy link
Contributor Author

I bumped the milestone to 19.1.

@soundsokay soundsokay changed the title [DRAFT] Upgrade to Xcode 15.4 Upgrade to Xcode 15.4 Jun 6, 2024
@soundsokay soundsokay requested a review from bozidarsevo June 6, 2024 15:24
@soundsokay soundsokay merged commit 494a015 into trunk Jun 7, 2024
23 of 24 checks passed
@soundsokay soundsokay deleted the dgalbraith/xcode-15.4-upgrade branch June 7, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozidarsevo bozidarsevo bozidarsevo approved these changes

Assignees
No one assigned
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. type: task An internally driven task.
Projects
None yet
Milestone
19.1
Development

Successfully merging this pull request may close these issues.
5 participants
@soundsokay @wpmobilebot @pmusolino @bozidarsevo @jkmassel