[Shipping labels] Get account settings and use in UI custom packages #14499
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,7 +56,12 @@ struct WooShippingCreateLabelsView: View { | |
| WooShippingServiceView(viewModel: shippingService) | ||
| .padding(.horizontal, -16) | ||
| } else { | ||
| if let storeOptions = viewModel.storeOptions { | ||
|
There was a problem hiding this comment. This is now much cleaner and easier to review 🥳 |
||
| WooShippingPackageAndRatePlaceholder(storeOptions: storeOptions) | ||
| } | ||
| else { | ||
| loadingView | ||
|
There was a problem hiding this comment. Having a loading view here feels a little odd to me, especially because the data isn't needed for this placeholder view — it just needs to be passed down to its child views. What do you think about setting the store options as an environment variable, instead? That way we could initialize this view without the This would also allow us to use the fallbacks from There was a problem hiding this comment. We will still need to do pick a place where we want to trigger the fetching/loading the data. And in theory that loading could take a longer time and user could get to a state in UI that needs this data and we need to show that something will be there. For example, I do not show any loading indicators and user gets to Add Package screen and Custom tab. I still do not have the store options therefor I do not have the dimension and weight units. Should I then show some indicator that something is loading? Because at that state we do not have all the data needed to show the UI and we cannot just show blank white screen. If I use environment variable again we need to decide when will we trigger fetching/loading so it would basically be the same just a different implementation. I can do it in a way that I trigger the initial load when we enter label creation flow and then if some part of the app needs the store options and they are not loaded yet I will show some loading indication there, basically showing the loading at the last possible state to avoid blocking user as little as possible. I will see if I will do that change here or in a separate PR when I see how big of a change would it be. There was a problem hiding this comment. Updated: Basically loading store options (account settings) when we enter the label creation screen, but showing loading indicator only if I get to the part of the UI that needs the store options and they are not loaded. That way in most cases users will not even see the loading indicator. 😊 Updated screen recordings in description There was a problem hiding this comment.
Why not use the dimension and weight units from |
||
| } | ||
| } | ||
| } | ||
| .padding(16) | ||
|
|
@@ -151,6 +156,28 @@ struct WooShippingCreateLabelsView: View { | |
| } | ||
| } | ||
| } | ||
| .onAppear() { | ||
| guard viewModel.storeOptions == nil else { return } | ||
| viewModel.loadStoreOptions() | ||
| } | ||
| } | ||
|
|
||
| private var loadingView: some View { | ||
| HStack { | ||
| Spacer() | ||
| if viewModel.isLoadingStoreOptions { | ||
| ActivityIndicator(isAnimating: .constant(true), style: .large) | ||
| } | ||
| else { | ||
| Button { | ||
| viewModel.loadStoreOptions() | ||
| } label: { | ||
| Image(systemName: "arrow.trianglehead.counterclockwise") | ||
| } | ||
| } | ||
| Spacer() | ||
| } | ||
| .padding() | ||
| } | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This import isn't needed in the view here