Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brand Updates] Fixes to some Woo icons #15021

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Jan 30, 2025

Description

This PR fixes two issues that were identified by the team today:

  1. It updates the app logo with a new export from Figma, as the previous export had a tiny transparent line at the top, that was tinted with white or black depending on the device theme.
  2. It updates the icon used in the Notification extension.

Steps to reproduce

  1. Install the new update on a real device.
  2. Confirm the logo doesn't have any white line at the top (move at the bottom dock for confirmation).
  3. Test a push notification.
  4. Long tap on the notification.
  5. Confirm the notification custom UI uses the new icon.

Testing information

I tested just the app logo for my side, as I don't have a physical device on me.

iPhone 16 simulator, iOS 18.1

Screenshots

Before After
Screenshot 2025-01-30 at 15 47 40 Screenshot 2025-01-30 at 15 46 44
Screenshot 2025-01-30 at 18 11 01 Screenshot 2025-01-30 at 18 08 23

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

The existing icon had a small transparent line at the top that caused a white line to appear above the icon on device.
@hichamboushaba hichamboushaba added type: bug A confirmed bug. category: design Layout and style elements in the UI or user interface, including color and animations. labels Jan 30, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 30, 2025

1 Warning
⚠️ This PR is assigned to the milestone 21.6. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@pmusolino pmusolino self-assigned this Jan 30, 2025
@hichamboushaba hichamboushaba added this to the 21.6 milestone Jan 30, 2025
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr15021-eaf1f25
Version21.5
Bundle IDcom.automattic.alpha.woocommerce
Commiteaf1f25
App Center BuildWooCommerce - Prototype Builds #12738
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Member

@pmusolino pmusolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to test just the app icon. As for notifications, they aren't arriving unless in production, so I couldn't replicate that part. However, the image update seems correct, so I am approving the PR.

@hichamboushaba hichamboushaba merged commit 53fe903 into trunk Jan 30, 2025
21 of 23 checks passed
@hichamboushaba hichamboushaba deleted the task/woo-2.0-icon-fixes branch January 30, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: design Layout and style elements in the UI or user interface, including color and animations. type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants