-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] Hide cart images when the view is too narrow #15028
Merged
joshheald
merged 9 commits into
trunk
from
task/hide-cart-images-when-the-view-is-too-narrow
Feb 5, 2025
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
02d74ff
Only show cart item images when it’s wide enough
joshheald f049a8e
Cell padding when the cart item image is hidden
joshheald 8caf60e
Show leading padding on cart items when no image
joshheald 5c0b46a
Rely on HStack spacing between x button and text
joshheald fbe1867
Make image hiding more reliable by passing width
joshheald c846d96
Remove development log
joshheald 5119757
Avoid secondary background changing in split view
joshheald 75f3331
Merge branch 'trunk' into task/hide-cart-images-when-the-view-is-too-…
joshheald 4dca723
Merge branch 'trunk' into task/hide-cart-images-when-the-view-is-too-…
joshheald File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Theoretically, we could pass values of the geometry reader to the item view, and then it could decide whether it's shown or not. Of course, this way, responsibilities would be split between two views.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, if we ever want it to be different between different types of cart item then we could do that, but it doesn't seem worth it just now