Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] Show payment method name in success screen #15030

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

joshheald
Copy link
Contributor

@joshheald joshheald commented Jan 31, 2025

Closes: #15011

Description

This PR adds cash or card in the payment success screen, appropriate for whichever payment method was used.

The new payment method enum could be used in future to improve our state management – i.e. we could keep hold of the card payment state even when we go to cash, and use the payment method enum to declare which is the active payment method.

Steps to reproduce

  1. Launch the app and open POS
  2. Add items and check out
  3. Take a payment

Observe that the success screen shows the payment method in the message.

Testing information

Screenshots

show.payment.method.in.success.screen.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@joshheald joshheald added type: task An internally driven task. feature: POS labels Jan 31, 2025
@joshheald joshheald added this to the 21.7 milestone Jan 31, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 31, 2025

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr15030-49d20e3
Version21.5
Bundle IDcom.automattic.alpha.woocommerce
Commit49d20e3
App Center BuildWooCommerce - Prototype Builds #12751
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@joshheald joshheald marked this pull request as ready for review January 31, 2025 13:09
@iamgabrielma iamgabrielma self-assigned this Jan 31, 2025
Copy link
Contributor

@iamgabrielma iamgabrielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! LGTM :shipit:

@joshheald joshheald merged commit 8098d27 into trunk Jan 31, 2025
14 checks passed
@joshheald joshheald deleted the issue/15011-payment-success-payment-method branch January 31, 2025 14:46
joshheald added a commit that referenced this pull request Feb 3, 2025
Previous changes merged in #15030 (8098d27) included a failing test.

This commit updates the test to check for the new string.
@joshheald joshheald mentioned this pull request Feb 3, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: POS type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Woo POS] The payment success screen is missing the payment type
3 participants