-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: now "Suggested by AI" label is visible in dark mode in Blaze Edit #15088
fix: now "Suggested by AI" label is visible in dark mode in Blaze Edit #15088
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering why the label colors were not re-rendered when switching between light & dark mode.
I checked the code and found that we were applying .environment(\.colorScheme, .light)
to the whole adPreview
view, while in fact we should apply it to the VStack containing the preview only.
That way, both the "Suggested by AI" label and "Edit Ad" button would be in the correct colors without having to apply different colors using colorScheme
like your fix.
WDYT?
@itsmeichigo yes I think it makes sense, I updated it here 76a310d |
…sible-in-the-dark-mode-for-blaze
Version |
RELEASE-NOTES.txt
Outdated
@@ -7,6 +7,7 @@ | |||
- [*] Product Details: Display cover tag on the first product image [https://github.com/woocommerce/woocommerce-ios/pull/15041] | |||
- [*] Payments: Update learn more links to open Stripe-specific docs when using that gateway [https://github.com/woocommerce/woocommerce-ios/pull/15035] | |||
- [*] Now, usernames and emails in text fields across multiple login views are no longer capitalized. [https://github.com/woocommerce/woocommerce-ios/pull/15002] | |||
- [*] Now "Suggested by AI" label is visible in dark mode in Blaze campaign creation flow. [https://github.com/woocommerce/woocommerce-ios/pull/15088] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be moved to 21.8
…sible-in-the-dark-mode-for-blaze
Closes: #14138
Description
This pull request addresses a visibility issue with the "Suggested by AI" label in dark mode.
Testing information
Screenshots
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: