Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: now "Suggested by AI" label is visible in dark mode in Blaze Edit #15088

Conversation

pmusolino
Copy link
Member

@pmusolino pmusolino commented Feb 7, 2025

Closes: #14138

Description

This pull request addresses a visibility issue with the "Suggested by AI" label in dark mode.

Testing information

  1. Log into a Blaze-eligible site.
  2. Trigger the Blaze campaign creation flow.
  3. Switch to dark mode.
  4. Observe the "Suggested by AI" label and verify its visibility.

Screenshots

Light mode Dark mode
Simulator Screenshot - iPhone 16 Pro - 2025-02-07 at 02 08 23 Simulator Screenshot - iPhone 16 Pro - 2025-02-07 at 02 08 18

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@pmusolino pmusolino added type: bug A confirmed bug. feature: Blaze Related to the integration of the Blaze ads platform labels Feb 7, 2025
@pmusolino pmusolino added this to the 21.7 milestone Feb 7, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 7, 2025

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr15088-0267b58
Version21.7
Bundle IDcom.automattic.alpha.woocommerce
Commit0267b58
App Center BuildWooCommerce - Prototype Builds #12884
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@itsmeichigo itsmeichigo self-assigned this Feb 7, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering why the label colors were not re-rendered when switching between light & dark mode.

I checked the code and found that we were applying .environment(\.colorScheme, .light) to the whole adPreview view, while in fact we should apply it to the VStack containing the preview only.

That way, both the "Suggested by AI" label and "Edit Ad" button would be in the correct colors without having to apply different colors using colorScheme like your fix.

WDYT?

@pmusolino
Copy link
Member Author

@itsmeichigo yes I think it makes sense, I updated it here 76a310d

@pmusolino pmusolino requested a review from itsmeichigo February 7, 2025 11:42
@wpmobilebot wpmobilebot modified the milestones: 21.7, 21.8 Feb 7, 2025
@wpmobilebot
Copy link
Collaborator

Version 21.7 has now entered code-freeze, so the milestone of this PR has been updated to 21.8.

@@ -7,6 +7,7 @@
- [*] Product Details: Display cover tag on the first product image [https://github.com/woocommerce/woocommerce-ios/pull/15041]
- [*] Payments: Update learn more links to open Stripe-specific docs when using that gateway [https://github.com/woocommerce/woocommerce-ios/pull/15035]
- [*] Now, usernames and emails in text fields across multiple login views are no longer capitalized. [https://github.com/woocommerce/woocommerce-ios/pull/15002]
- [*] Now "Suggested by AI" label is visible in dark mode in Blaze campaign creation flow. [https://github.com/woocommerce/woocommerce-ios/pull/15088]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved to 21.8

@pmusolino pmusolino enabled auto-merge February 10, 2025 15:22
@pmusolino pmusolino merged commit 992f3db into trunk Feb 10, 2025
12 checks passed
@pmusolino pmusolino deleted the issue/14138-suggested-by-AI-label-is-not-visible-in-the-dark-mode-for-blaze branch February 10, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Blaze Related to the integration of the Blaze ads platform type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Suggested by AI" label is not visible in the dark mode
3 participants