Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blaze] Enhance loading UI for product image in Blaze Campaign Creation form #15098

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

pmusolino
Copy link
Member

@pmusolino pmusolino commented Feb 7, 2025

Fixes #15094
While creating a new Blaze Ad Campaign, during the loading process, you might notice a large t-shirt on the transition screen. This t-shirt serves as the placeholder for the campaign image in case there is no image associated with the product.

So in this PR I

  • Updated BlazeCampaignCreationForm to add redacted and shimmering effects when loading product image.
  • Updated isLoadingProductImage visibility in BlazeCampaignCreationFormViewModel to be read-only and set default to true since the image will be fetched async.

Steps to reproduce

  1. Ideally start with a clean installation, so you don't have images in cache.
  2. Use a store that is eligible for Blaze
  3. While creating a new Blaze ad campaign, notice that the big t-shirt icon in the transition.

Testing information

Repeat the steps to reproduce, and you should now see a redacted and shimmering effect on the loading product image, or a placeholder t-shirt image if there is no image to load.

Video

The error alert in this video appears because the AI suggestion service was offline while recording the video. C069RG07W6S/p1738935520270549

fix.issue.blaze.loading.mp4


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

- Update BlazeCampaignCreationForm.swift to add redacted and shimmering effects when loading product image
- Modify isLoadingProductImage visibility in BlazeCampaignCreationFormViewModel.swift to be read-only and set default to true
@pmusolino pmusolino added type: bug A confirmed bug. feature: Blaze Related to the integration of the Blaze ads platform labels Feb 7, 2025
@pmusolino pmusolino added this to the 21.8 milestone Feb 7, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 7, 2025

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr15098-c6a5deb
Version21.7
Bundle IDcom.automattic.alpha.woocommerce
Commitc6a5deb
App Center BuildWooCommerce - Prototype Builds #12883
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@itsmeichigo itsmeichigo self-assigned this Feb 10, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on simulator iPhone 16 Pro iOS 18.2 and confirmed that the glitch is no longer present.

@pmusolino pmusolino enabled auto-merge February 10, 2025 14:42
@pmusolino pmusolino merged commit 5a44075 into trunk Feb 10, 2025
12 checks passed
@pmusolino pmusolino deleted the issue/15094-blaze-glitch-while-loading-ad-creation branch February 10, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Blaze Related to the integration of the Blaze ads platform type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blaze: glitch while loading Blaze Ad Creation
3 participants