Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the correct UI is shown in the new WooCommerce payments settings. #282

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

iamdharmesh
Copy link
Member

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

WooCommerce is modernizing the WooCommerce Payments experience with a new React-based interface for the core WooCommerce Payments settings page. This PR makes changes to ensure that payment methods added by this extension are shown correctly in the new UI.

Note

Since the Square account connection settings are located on the Square settings page rather than in individual payment gateway settings, the "Complete setup" button should redirect to the Square settings instead of the individual payment gateway settings page. However, on the current classic payment settings page, the "Finish setup" button also redirects to the individual settings page. We can ignore this for now, but I just want to add a note to consider it for future enhancements.

Closes #281

Steps to test the changes in this Pull Request:

Verify that the payment methods list displays the correct buttons and statuses for each payment method.

  • If the Square credentials are not set or the Square account is not connected, display the "Complete setup" button and the "Action required" status.
    Screenshot 2025-02-07 at 7 22 35 PM

  • If the Square account is configured but the method is not enabled, display the "Enable" and "Manage" buttons with an Inactive status.
    image

  • If the payment method credentials are configured and the method is enabled, display the "Manage" button with an "Active" status for production and "Test Mode" for the sandbox environment.

    • Sandbox
      image

    • Production
      image

Changelog entry

Fix - Ensure payment methods display the correct buttons and statuses in the new WooCommerce Payments settings.

@iamdharmesh iamdharmesh self-assigned this Feb 7, 2025
@dkotter dkotter added the needs: UAT The Issue/PR needs to go through UAT label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: UAT The Issue/PR needs to go through UAT status: e2e tests passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Square Payment Methods Displayed as a Single Option Instead of Separate Methods
2 participants