Skip to content

Commit

Permalink
CI: Don't xcbeautify Swift Testing suites (pointfreeco#3425)
Browse files Browse the repository at this point in the history
* wip

* benchmark update

* wip

* Add CI for benchmarks

* wip

* Update benchmark.yml

* Update benchmark.yml

* Delete Benchmarks/Benchmarks/swift-composable-architecture-benchmark/ Benchmarks.swift

* Update benchmark.yml

* Update benchmark.yml

* Update Benchmarks.swift

* wip

* Delete .github/workflows/benchmark.yml

* Update Benchmarks.swift

* Add slight delay for expected failure

Test expected failure is flakey, so hopefully will pass more
consistently now.

---------

Co-authored-by: Brandon Williams <[email protected]>
  • Loading branch information
stephencelis and mbrandonw authored Oct 7, 2024
1 parent 00cd6aa commit 61e3809
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 12 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,21 +98,21 @@ jobs:
- name: Update mtime for incremental builds
uses: chetan/git-restore-mtime-action@v2
- name: CaseStudies (SwiftUI)
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="CaseStudies (SwiftUI)" xcodebuild
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="CaseStudies (SwiftUI)" xcodebuild-raw
- name: CaseStudies (UIKit)
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="CaseStudies (UIKit)" xcodebuild
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="CaseStudies (UIKit)" xcodebuild-raw
- name: Search
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="Search" xcodebuild
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="Search" xcodebuild-raw
- name: SyncUps
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="SyncUps" xcodebuild
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="SyncUps" xcodebuild-raw
- name: SpeechRecognition
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="SpeechRecognition" xcodebuild
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="SpeechRecognition" xcodebuild-raw
- name: TicTacToe
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="TicTacToe" xcodebuild
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="TicTacToe" xcodebuild-raw
- name: Todos
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="Todos" xcodebuild
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="Todos" xcodebuild-raw
- name: VoiceMemos
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="VoiceMemos" xcodebuild
run: make DERIVED_DATA_PATH=~/.derivedData SCHEME="VoiceMemos" xcodebuild-raw

check-macro-compatibility:
name: Check Macro Compatibility
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"originHash" : "9b77567b796b05ea9be9bbcac20aca003b91f34244a7fd2740f2b5306c013c45",
"pins" : [
{
"identity" : "combine-schedulers",
Expand Down Expand Up @@ -154,5 +155,5 @@
}
}
],
"version" : 2
"version" : 3
}
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ TEST_RUNNER_CI = $(CI)
xcodebuild:
$(XCODEBUILD)

# Workaround for debugging Swift Testing tests: https://github.com/cpisciotta/xcbeautify/issues/313
xcodebuild-raw:
$(XCODEBUILD_COMMAND)

build-for-library-evolution:
swift build \
-q \
Expand Down
7 changes: 4 additions & 3 deletions Tests/ComposableArchitectureTests/EffectRunTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ final class EffectRunTests: BaseTCATestCase {
}

@MainActor
func testRunEscapeFailure() async {
func testRunEscapeFailure() async throws {
XCTExpectFailure {
$0.compactDescription == """
failed - An action was sent from a completed effect:
Expand Down Expand Up @@ -163,8 +163,9 @@ final class EffectRunTests: BaseTCATestCase {
}
}

let viewStore = ViewStore(store, observe: { $0 })
await viewStore.send(.tap).finish()
await store.send(.tap).finish()
await queue.advance(by: .seconds(1))

try await Task.sleep(nanoseconds: 100_000_000)
}
}

0 comments on commit 61e3809

Please sign in to comment.