카테고리 별 템플릿 개수 조회 #1031
Open
카테고리 별 템플릿 개수 조회 #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jminkkk
reviewed
Jan 14, 2025
backend/submodules/private
Outdated
There was a problem hiding this comment.
요고 파일은 포함되어야 하는 거 맞을까요?
체크 한번 부탁드려요~!
| @@ -76,6 +76,15 @@ public Template update( | |||
| return template; | |||
| } | |||
|
|
|||
| private void checkCategoryChanged(Category category, Template template) { | |||
There was a problem hiding this comment.
Suggested change
| private void checkCategoryChanged(Category category, Template template) { | |
| private void updateCategoryCount(Category newCategory, Template template) { |
메서드명과 달리 단순 체크만 하지는 않고 내부 로직이 있어서 변경 제안해요!
84, 85라인 변수명도 조금 헷갈릴 수 있을 것 같아서 더 명확하게 제안해봅니당~!
There was a problem hiding this comment.
변수명에 new가 들어가는게 묘하게 불편해서 changed로 변경하였습니다!
HoeSeong123
force-pushed
the
feat/967-count-template-by-category
branch
from
f70727c to
a3f1e2e
Compare
HoeSeong123
commented
Jan 19, 2025
backend/submodules/private
Outdated
There was a problem hiding this comment.
이거 커밋에서 지우고 강제푸시 했는데도 남아있네요?
그런데 들어가서 확인해보면 아무것도 변경된 건 없다고 뜨긴 합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
close #967
📍주요 변경 사항
🎸기타
🍗 PR 첫 리뷰 마감 기한
1/17(금)23:59 (여행 이슈로 넉넉하게 두었습니다)