feat-be: 평가 테이블에 평가자 이름 필드 추가 및 API 변경 #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
1734436773.727529 |
|
1734436774.129299 |
Chocochip101
requested changes
Dec 18, 2024
| @@ -81,8 +81,8 @@ private void runDataLoader() { | |||
| LocalDateTime endDate = LocalDateTime.of(2054, 10, 16, 10, 0, 0); | |||
| dashboardRepository.save(dashboard); | |||
| String description = """ | |||
| <h2>2025 신입생 (7기) 선발 일정 </h2><p><br></p><ol><li data-list=\"bullet\"><span class=\"ql-ui\" contenteditable=\"false\"></span><strong>서류접수:</strong> 2024년 10월 6일(금) 오후 3시 ~ 10월 16일(월) 오전 10시</li><li data-list=\"bullet\"><span class=\"ql-ui\" contenteditable=\"false\"></span><strong>프리코스:</strong> 2024년 10월 19일(목) ~ 11월 15일(수)</li><li data-list=\"bullet\"><span class=\"ql-ui\" contenteditable=\"false\"></span><strong>1차 합격자 발표:</strong> 2024년 12월 11일(월) 오후 3시, 개별 E-mail 통보</li><li data-list=\"bullet\"><span class=\"ql-ui\" contenteditable=\"false\"></span><strong>최종 코딩 테스트:</strong> 2024년 12월 16일(토)</li><li data-list=\"bullet\"><span class=\"ql-ui\" contenteditable=\"false\"></span><strong>최종 합격자 발표:</strong> 2024년 12월 27일(수) 오후 3시, 개별 E-mail 통보 </li></ol><p><br></p><h2>2025 신입생 (7기) 교육 기간 </h2><p><br></p><ol><li data-list=\"bullet\"><span class=\"ql-ui\" contenteditable=\"false\"></span>2025년 2월 ~ 11월 (약 10개월) </li></ol> | |||
There was a problem hiding this comment.
매번 개행 때문에 변경되서 거슬리는군요. 다음에 이를 static 파일로 뺄 궁리를 해봐야겠네요.
| @@ -33,6 +33,8 @@ public class Evaluation extends BaseEntity implements SecureResource { | |||
| @Column(name = "evaluation_id") | |||
| private Long id; | |||
|
|
|||
| private String evaluator; | |||
Comment on lines
60
to
62
| evaluation.getContent().equals(request.content()) | ||
| && evaluation.getScore().equals(request.score()) | ||
| && evaluation.getEvaluator().equals(request.evaluator()) |
There was a problem hiding this comment.
도메인 검증 로직으로 빼는건 어떤가요?
Suggested change
| evaluation.getContent().equals(request.content()) | |
| && evaluation.getScore().equals(request.score()) | |
| && evaluation.getEvaluator().equals(request.evaluator()) | |
| evaluation.isContent(...) && evaluation.isScore(...) && evaluation.isEvaluator(...) |
cutehumanS2
approved these changes
Dec 19, 2024
Comment on lines
+7
to
+9
| @NotNull(message = "평가자 이름은 필수 값입니다.") | ||
| String evaluator, | ||
|
|
There was a problem hiding this comment.
[단순 질문]
평가자 이름도 수정할 수 있게 하는 편이 좋을까요?
명오에게만 물을 사항은 아니지만, 여기에 남길게요.
There was a problem hiding this comment.
저는 개인적으로 현재는 필요하다고 생각합니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
목적
작업 세부사항
참고 사항
EVAL_NAME_01
closes #957