-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop backend #121
Closed
Closed
Develop backend #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moim.currentPeople이 null로 초기화되는 문제 해결
- service에서 반환된 dto를 이용하는게 아닌, repository에서 반환된 domain을 이용하여 테스트
Controller에서 Swagger 코드 분리
날짜 / 시간 및 기타 코드 컨벤션 통일
서비스 테스트 시 레포지토리에서 잘못 호출되는 메서드를 수정
참여자 닉네임 생성, 모임의 참여자 조회 기능 생성
CI 스크립트를 수정하여 새로 올라온 코드 기반으로 동작하는 지 확인
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적이 무엇인가요?
이슈 ID는 무엇인가요?
설명
질문 혹은 공유 사항 (Optional)