Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

파이어베이스 서비스워커가 동작이 안되는 곳에서도 동작 제한 #536

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

ss0526100
Copy link
Contributor

PR의 목적이 무엇인가요?

파이어베이스 서비스워커가 동작이 안되는 곳에서도 동작하도록 한다

이슈 ID는 무엇인가요?

설명

이로 인해 아이폰 카카오 브라우저에서도 사용가능하다

closed #535

@ss0526100 ss0526100 added FE 프론트엔드 관련 이슈입니다. 🚑 버그 fix (develop에서 파생된 문제) labels Sep 9, 2024
@ss0526100 ss0526100 requested review from cys4585 and jaeml06 September 9, 2024 07:31
Copy link
Contributor

@cys4585 cys4585 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다아

Copy link
Contributor

@jaeml06 jaeml06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했습니다

Comment on lines +1 to +6
export default function checkCanUseFirebase() {
if (location.hostname === 'localhost') return true;
if (location.protocol !== 'https') return false;
if (navigator.userAgent.indexOf('KAKAO') >= 0) return false;
return true;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

카카오톡 내장 브라우저 때문에 발생하는 문제를 해결하기 위해 작성하신 코드군요

@jaeml06 jaeml06 merged commit 3456f10 into develop-frontend Sep 9, 2024
1 check passed
@jaeml06 jaeml06 deleted the fix/#535 branch September 9, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE 프론트엔드 관련 이슈입니다. 🚑 버그 fix (develop에서 파생된 문제)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants