코드 스플리팅 적용 #567
Merged
코드 스플리팅 적용 #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeml06
reviewed
Sep 25, 2024
frontend/src/routes/router.tsx
Outdated
| @@ -165,11 +169,17 @@ const router = createBrowserRouter( | |||
| routesConfig.map((route) => ({ | |||
| path: route.path, | |||
| element: route.requiresAuth ? ( | |||
| <ProtectedRoute>{route.element}</ProtectedRoute> | |||
| <Suspense fallback={<div>Loading...</div>}> | |||
There was a problem hiding this comment.
Lazy 로딩을 적용하지 않기로 했는데 Suspense를 제거하지 않는 추가적인 이유가 있을까요?
ss0526100
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적이 무엇인가요?
이슈 ID는 무엇인가요?
설명
코드 스플리팅 적용 및 결과 정리해두었습니다. 이미 공유는 되었겠지만 말씀 드려보면, lazy loading은 효과에 비해 부작용(모든 페이지 로드 시간 소요)이 크기 때문에 적용하지 않았습니다. 아직 우리 앱이 작기 때문에 동적 스플리팅의 효과를 보기는 어려울 것 같습니다. 정적 코드 스플리팅만 적용했습니다. 제 PC, network fast 4g 기준으로 메인 페이지 번들 파일 로드하는 데 걸리는 시간이 9.8초에서 4.8초로 단축되었습니다.
https://www.notion.so/5-6b414bde911b420aaa53f9c02a2c3854?pvs=4
질문 혹은 공유 사항 (Optional)