채팅방 안내면 진다 도입 후 바 ui 구현 #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeml06
approved these changes
Oct 16, 2024
| .catch((error) => { | ||
| console.log('Service Worker registration failed:', error); | ||
| .catch(() => { | ||
| // console.log('Service Worker registration failed:', error); |
There was a problem hiding this comment.
이부분 console.log도 지워야할 것 같아요
Comment on lines
+9
to
+13
| export const isMoimChatRoomDetail = ( | ||
| detail: ChatRoomDetail, | ||
| ): detail is MoimChatRoomDetail => { | ||
| return (detail as MoimChatRoomDetail).attributes.moimId !== undefined; | ||
| }; |
| queryFn: () => getChatRoomDetail(chatRoomId), | ||
| }); | ||
|
|
||
| return { chatRoomDetail: data, isLoading }; |
There was a problem hiding this comment.
data 변수명 그대로 return하고 사용처에서 변수명을 지정해서 사용하는게 더 쉽게 사용할 수 있을 것 같아요
| <DefaultPageLayout.TriHeader> | ||
| <DefaultPageLayout.TriHeader.Left> | ||
| <h2 css={[theme.typography.h5, common.nonScroll]}> | ||
| <> |
There was a problem hiding this comment.
현재 <>를 사용하면 stroybook에서 에러가 발생해서 를 사용했는데 해결했나요?
cys4585
approved these changes
Oct 16, 2024
Comment on lines
63
to
77
| (nowChatRoomType === 'MOIM' || '') && | ||
| (chatPreview.isStarted ? '모임 후' : '모임 전') | ||
| } | ||
| fontColor={ | ||
| (nowChatRoomType === 'MOIM' || undefined) && | ||
| (chatPreview.isStarted | ||
| ? theme.colorPalette.yellow[800] | ||
| : theme.colorPalette.white[100]) | ||
| } | ||
| themeColor={ | ||
| (nowChatRoomType === 'MOIM' || undefined) && | ||
| (chatPreview.isStarted | ||
| ? theme.colorPalette.yellow[50] | ||
| : theme.colorPalette.orange[100]) | ||
| } |
There was a problem hiding this comment.
tagValue만 빈문자열로 비교한 이유를 여쭤봐도 될까요?
Comment on lines
30
to
37
| <div key={formatYyyymmddToKorean(chat.date, '-', true)}> | ||
| <ChattingRoomSeparator | ||
| string={formatYyyymmddToKorean(chat.date, '-', true)} | ||
| /> | ||
| <Chat key={chat.chatId} chat={chat}> | ||
| <ChatChildren chat={chat} /> | ||
| </Chat> | ||
| </> | ||
| </div> |
There was a problem hiding this comment.
div의 key에도 chat의 id를 넣어주면 됩니다! 그리고 최상위 엘리먼트에만 넣으면 되어요 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적이 무엇인가요?
이슈 ID는 무엇인가요?
설명
추가된 태그
각 프리뷰
안걸린 경우 헤더
걸린 경우 헤더
아직 api가 덜만들어져서 불안정할 수 있습니다.
closed #624