Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.1.1/AN-UI] 특성 화면 및 디테일 반응형 UI 구현하기 #386

Merged
merged 5 commits into from
Oct 24, 2024
Merged

[1.1.1/AN-UI] 특성 화면 및 디테일 반응형 UI 구현하기 #386

merged 5 commits into from
Oct 24, 2024

Conversation

kkosang
Copy link
Contributor

@kkosang kkosang commented Oct 22, 2024 •
edited
Loading

작업 영상

an.ui._.webm
an.ui._.webm

작업한 내용

  • 특성 버튼 테투리 변경 및 설명 1줄로 표시
  • 가로모드 대응
  • width600 이상 화면 대응

PR 포인트

  • 영상이 이번에도 반대네... 😅

🚀Next Feature

  • 예니PR 머지되면 바이옴이랑 바이옴 디테일 화면 대응할게용
  • 그동안은 Koin DI 하겠습니다

sh1mj1
sh1mj1 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@sh1mj1 sh1mj1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

영상이 이번에도 반대네... 😅

ㅋㅋㅋㅋ

JoYehyun99
JoYehyun99 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@JoYehyun99 JoYehyun99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳 👍

murjune
murjune approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@murjune murjune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳 👍

@kkosang
Merge branch 'an/develop' into an/ui/ability_responsive_ui
dc553f7 
# Conflicts:
#	android/app/src/main/res/values-sw600dp/dimens.xml
#	android/app/src/main/res/values/dimens.xml
@kkosang kkosang merged commit a46474e into an/develop Oct 24, 2024
2 checks passed
@kkosang kkosang deleted the an/ui/ability_responsive_ui branch October 24, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoYehyun99 JoYehyun99 JoYehyun99 approved these changes

@murjune murjune murjune approved these changes

@sh1mj1 sh1mj1 sh1mj1 approved these changes

Assignees

@kkosang kkosang

Labels
AN_UI 🎨 안드 UI 작업 v1.1.1 🏷️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kkosang @JoYehyun99 @murjune @sh1mj1