Fix memory leak in EnhancedMovementMethod #1086
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
With a help from Leak Canary I found a leak in EnhancedMovementMethod.
In this PR we are using weak reference for a click listener. Task list listener is not leaking, so it's ok to keep it as is.
Test
Review
@[USER_NAME]
Make sure strings will be translated:
strings.xml
as a part of the integration PR.