Upgrade to Xcode 16.2 #1404
Open
Upgrade to Xcode 16.2 #1404
+385
−274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Non-'@objc' instance method in extensions cannot be overridden; > use 'public' instead
Ideally, this should be removed once the warnings have been addressed
…' into mokagio/xcode-15.3
@mokagio This should fix the `testPaste{Image,Video}WithoutFormatting` test failures. - I have searched the code for `decodeObject(forKey` occurrences and confirmed there wasn't any left - But I have not triple-checked that *every* custom subclass of anything we might encode in our `NSAttributedString` attributes have had `+supportsSecureCoding` redefined Indeed, apparently, **even if** the parent class already overrides it to return `true`, subclasses which override `init?(coder:)`/`encode(with:)` from their parent class need to also re-override `+supportsSecureCoding`. I've added the overrides in classes that I've modified, but there may be more classes that might not be covered by our unit tests around archiving/pasting but would still require it to be added? So would be worth making another pass to be sure we didn't forget any,
…inText` Since newer versions of iOS use this new `public.utf8-plain-text` UTI instead of `public.plain-text` like in previous OS versions.
This reverts commit 5c3004b, because I'm not convinced that's a good idea. We should double-check that **not** having `+supportsSecureCoding` declared on this subclass doesn't make it fail to be copy/pasted (i.e. archived/unarchived)—like similar cases happened when running Aztec tests. Or if we need `+supportsSecureCoding`, we need to find a way to override/redefine it across module boundaries…
Fix - Shortcode test
This is in line with our Buildkite/YML pipeline standard.
mokagio
force-pushed
the
mokagio-olivier/xcode-16.2
branch
from
44a3cbb to
834b097
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks up where #1392 left, upgrading the project to work with Xcode 16.2
This long overdue upgrade was prompted by looking into merging Support SPM installation #1379 and realizing that CI was not up to date via #1403
Notice that this PR adds custom GitHub status check names. I already updated the settings to require those names. After this PR is merged, and so is #1391, we'll need to update other PRs we want to merge by merging
trunkinto them or rebasing.CHANGELOG.mdif necessary. — N.A.