feat: GutenbergKit code editor #21582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
added
[Type] Enhancement
[Type] Broken Window
Gutenberg
Generated by 🚫 Danger |
14 tasks
Project dependencies changesThe following changes in project dependencies were detected (configuration listtree +--- project :libs:editor
-| \--- org.wordpress.gutenbergkit:android:55-a490cd3d2d70ad4bba501655f83fdc42b404d502
+| \--- org.wordpress.gutenbergkit:android:trunk-cc52214a50893b41898607ac0bff7f2787b085bb
-\--- org.wordpress.gutenbergkit:android:55-a490cd3d2d70ad4bba501655f83fdc42b404d502 (*)
+\--- org.wordpress.gutenbergkit:android:trunk-cc52214a50893b41898607ac0bff7f2787b085bb (*) |
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21582-be0696d | |
| Commit | be0696d | |
| Direct Download | wordpress-prototype-build-pr21582-be0696d.apk |
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21582-be0696d | |
| Commit | be0696d | |
| Direct Download | jetpack-prototype-build-pr21582-be0696d.apk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #21582 +/- ##
=======================================
Coverage 39.48% 39.48%
=======================================
Files 2117 2117
Lines 99464 99464
Branches 15296 15296
=======================================
Hits 39269 39269
Misses 56714 56714
Partials 3481 3481 ☔ View full report in Codecov by Sentry. |
dcalhoun
commented
Jan 14, 2025
Comment on lines
-1429
to
-1433
| viewHtmlModeMenuItem.setVisible( | ||
| (((editorFragment is AztecEditorFragment) | ||
| || (editorFragment is GutenbergEditorFragment))) && showMenuItems |
There was a problem hiding this comment.
There does not appear to be a reason to check the editor fragment type, as this now applies to all editor types—Aztec, Gutenberg Mobile, and GutenbergKit.
dcalhoun
force-pushed
the
feat/gutenberg-kit-code-editor
branch
from
9c9df05 to
a2e82a7
Compare
dcalhoun
removed
the
Do Not Merge
Allow editing post content with the code editor.
The `editorFragment` check includes all possible fragment types, thus it is unnecessary. Android Studio recommends using the property access syntax rather than the setter method.
dcalhoun
force-pushed
the
feat/gutenberg-kit-code-editor
branch
from
a2e82a7 to
be0696d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable toggling the code editor within GutenbergKit.
Related:
To Test:
See wordpress-mobile/GutenbergKit#60.
Regression Notes
Regressions within Aztec and Gutenberg Mobile.
Manually tested the editors.
Deemed unnecessary for the experimental editor.
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):